Skip to content

render diameter when a feature is selected#9732

Open
k-yle wants to merge 1 commit into
openstreetmap:developfrom
k-yle:radius
Open

render diameter when a feature is selected#9732
k-yle wants to merge 1 commit into
openstreetmap:developfrom
k-yle:radius

Conversation

@k-yle

@k-yle k-yle commented Jul 6, 2023

Copy link
Copy Markdown
Collaborator

If a node has a tag like diameter or radius, iD will now render a circle when you select the node.

image

  • As per the wiki, spaces are allowed between the number and the unit.
  • These tags are supported: diameter, diameter_crown, hole:diameter, radius, crown_radius, and seamark:anchor_berth:radius.
  • Many different units of measurement are supported, including a combination of feet and inches
  • The default unit is m for all tags except diameter, where the default unit is mm and seamark:anchor_berth:radius where the unit is defined by a separate tag (seamark:anchor_berth:units)

does not exactly fix #9189, but solves the problem with an alternative solution

@tordans

tordans commented Sep 5, 2024

Copy link
Copy Markdown
Collaborator

I really like this idea. We are using diameter on trees a lot in Neukölln to render a more realistic Map like https://strassenraumkarte.osm-berlin.org/?map=micromap#19/52.47378/13.43892 so that will help at lot to get a feel for this value.

@tyrasd tyrasd added the usability An issue with ease-of-use or design label Jan 15, 2025
@k-yle k-yle marked this pull request as ready for review July 16, 2025 11:21
@k-yle k-yle force-pushed the radius branch 2 times, most recently from 31ed918 to 5155107 Compare July 16, 2025 11:39
Comment thread modules/svg/points.js Outdated
Comment thread modules/core/planar.ts Outdated
Comment thread modules/core/planar.ts Outdated
Comment thread modules/core/planar.ts Outdated
Comment thread modules/svg/points.js Outdated

@tyrasd tyrasd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the concrete styling: I think the red-ish color is a little bit distracting in this context. It reminiscent of the color iD uses for buildings, or could be interpreted as an error even.

What about going with a neutral styling similar to the viewport cones?

image
g.point .radius,
g.vertex .radius {
    fill: #333;
    fill-opacity: 0.6;
    stroke: #fff;
    stroke-width: 0.5px;
    stroke-opacity: 0.75;
}
.fill-wireframe .radius {
    fill: none;
}

Comment thread css/20_map.css Outdated
Comment thread modules/svg/vertices.js Outdated
@k-yle

k-yle commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator Author

styling also changed per suggestions above:
image
image

@k-yle k-yle added the map-renderer An issue with how things are rendered in the map label Apr 1, 2026
@matkoniecz

Copy link
Copy Markdown
Contributor

@k-yle

This branch has conflicts that must be resolved

@k-yle

k-yle commented May 8, 2026

Copy link
Copy Markdown
Collaborator Author

@matkoniecz almost all my PRs will have that label, because editing the CHANGELOG file will create conflicts if a different PR is merged first

Comment thread css/20_map.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

map-renderer An issue with how things are rendered in the map usability An issue with ease-of-use or design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create empty node from empty area

5 participants