render diameter when a feature is selected#9732
Open
k-yle wants to merge 1 commit into
Open
Conversation
Collaborator
|
I really like this idea. We are using diameter on trees a lot in Neukölln to render a more realistic Map like https://strassenraumkarte.osm-berlin.org/?map=micromap#19/52.47378/13.43892 so that will help at lot to get a feel for this value. |
31ed918 to
5155107
Compare
tyrasd
reviewed
Jul 17, 2025
1ec5
reviewed
Jul 18, 2025
1ec5
reviewed
Jul 18, 2025
tyrasd
reviewed
Jul 22, 2025
tyrasd
left a comment
Member
There was a problem hiding this comment.
Regarding the concrete styling: I think the red-ish color is a little bit distracting in this context. It reminiscent of the color iD uses for buildings, or could be interpreted as an error even.
What about going with a neutral styling similar to the viewport cones?
g.point .radius,
g.vertex .radius {
fill: #333;
fill-opacity: 0.6;
stroke: #fff;
stroke-width: 0.5px;
stroke-opacity: 0.75;
}
.fill-wireframe .radius {
fill: none;
}0dd5a12 to
18f978f
Compare
Collaborator
Author
Contributor
|
Collaborator
Author
|
@matkoniecz almost all my PRs will have that label, because editing the CHANGELOG file will create conflicts if a different PR is merged first |
tordans
reviewed
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


If a node has a tag like
diameterorradius, iD will now render a circle when you select the node.diameter,diameter_crown,hole:diameter,radius,crown_radius, andseamark:anchor_berth:radius.mfor all tags exceptdiameter, where the default unit ismmandseamark:anchor_berth:radiuswhere the unit is defined by a separate tag (seamark:anchor_berth:units)does not exactly fix #9189, but solves the problem with an alternative solution