Upgrade maplibre-gl dependency, fixing CJK labels#6377
Closed
mapmeld wants to merge 2 commits intoopenstreetmap:masterfrom
Closed
Upgrade maplibre-gl dependency, fixing CJK labels#6377mapmeld wants to merge 2 commits intoopenstreetmap:masterfrom
mapmeld wants to merge 2 commits intoopenstreetmap:masterfrom
Conversation
Member
|
I wonder why dependabot hasn't already suggested this? In any case you need to fix the lock file... |
Contributor
Author
|
oh! It looks like yarn.lock was mostly on 5.7.0 already and we just didn't have an upgrade in package.json I had this PR queued up for when maplibre-gl was released and didn't notice it is fixed on the OSM main site already. |
Member
|
Ah yes dependabot already bumped it in #6357. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chinese map labels with the new vector tile / MapLibre GL layers haven't been rendering properly in the Chrome browser.
When the user sets their UI language to Traditional Chinese, these two labels should have these characters rendered as 门 and 北:
In mapbox/tiny-sdf#58 and maplibre/maplibre-gl-js#6223 we added support for MapLibre to pass the document language to Tiny-SDF, and Tiny-SDF sets the language in the canvas
ctx.langto render CJK characters. So I think all that's left is upgradingmaplibre-glhere. If we need to update yarn.lock too please let me know.Note: in the MapLibre GL layers, switching the UI language changes which
nametag we prefer. So we're rendering CJK characters in the user's language and NOT trying to render Hong Kong in Traditional Chinese, Beijing in Simplified Chinese, Tokyo in Japanese, etc.