Skip to content
This repository was archived by the owner on Oct 6, 2022. It is now read-only.

Make my fork (@brysgo/graphql-query-generator) go away#27

Open
brysgo wants to merge 0 commit intoopentable:masterfrom
brysgo-forks:master
Open

Make my fork (@brysgo/graphql-query-generator) go away#27
brysgo wants to merge 0 commit intoopentable:masterfrom
brysgo-forks:master

Conversation

@brysgo
Copy link
Copy Markdown

@brysgo brysgo commented Aug 15, 2019

  1. Include field names in test query alias for better readability
  2. Expose function for executing introspection query as alternative to http request
  3. Merge graphql update and peer dep from @kamilchm

package.json Outdated
{
"name": "graphql-query-generator",
"version": "0.5.5",
"name": "@brysgo/graphql-query-generator",
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure the @brysgo/ goes away along with the different version number if this gets merged.

@brysgo
Copy link
Copy Markdown
Author

brysgo commented Aug 19, 2019

@lobut - Can you help me out and look at this PR, for some reason I have colleagues that don't like the idea of using a fork. Would you mind taking a quick look at this and giving some feedback? We've already caught a few bugs with the change, but I'd love for it to be merged upstream.

@pbazydlo
Copy link
Copy Markdown
Contributor

@arcaartem @ajcw @mattiaerre is any of you able to give me rights to review+merge, or would be able to it for us? (maybe Chris Cartlidge, but I can't seem to be able to find his handle :( )

@arcaartem
Copy link
Copy Markdown

@pbazydlo @brysgo sorry for the late reply; I've been on holiday last 2 weeks. Tagging @chriscartlidge and
@nchallapalli as I think they're the most qualified to review this PR.

@chriscartlidge
Copy link
Copy Markdown

I've been on PTO. I'll check this out tomorrow.

@brysgo
Copy link
Copy Markdown
Author

brysgo commented Sep 8, 2019

thanks @chriscartlidge - looking forward to working with you on this

@bai
Copy link
Copy Markdown

bai commented Mar 16, 2020

👋 Is there any chance this could get merged? Master is quite out of date by now 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants