-
Notifications
You must be signed in to change notification settings - Fork 2
[DSPX-3302] (3/5) otdf-local multi-instance refactor #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dmihalcik-virtru
wants to merge
18
commits into
DSPX-3302-02-platform-installer
Choose a base branch
from
DSPX-3302-03-multi-instance
base: DSPX-3302-02-platform-installer
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
fab7b16
feat(otdf-sdk-mgr): manage platform service + install scenario (DSPX-…
dmihalcik-virtru a5e6229
fix(otdf-sdk-mgr): repair install scenario + harden silent failures
dmihalcik-virtru 64132cb
style(otdf-sdk-mgr): ruff format
dmihalcik-virtru 6a0e805
refactor(otdf-sdk-mgr): address PR review feedback on platform installer
dmihalcik-virtru eb76839
docs+chore: require uv run ruff/pyright pre-commit; fix cli_scenario …
dmihalcik-virtru 5b75907
docs(agents): expand and reorganize AGENTS.md across packages
dmihalcik-virtru 270fb12
feat(otdf-sdk-mgr): install tip --ref for branches, PRs, and SHAs
dmihalcik-virtru acd0899
fixup addd platform source to gitignore
dmihalcik-virtru 4c159a5
fix(otdf-sdk-mgr): normalize only semver tail for immutable platform …
dmihalcik-virtru 959a96d
fix(otdf-sdk-mgr): address PR review critical issues
dmihalcik-virtru 34568fa
fix(otdf-sdk-mgr): tighten error handling and dedupe APIs
dmihalcik-virtru 9df465a
test(otdf-sdk-mgr): cover mutable-rebuild, PR refspec, registry
dmihalcik-virtru 5ea87e7
fix(otdf-sdk-mgr): address remaining PR review items
dmihalcik-virtru ec578ac
docs(schema): document KAS preview features fields
dmihalcik-virtru a20470e
feat(otdf-local): multi-instance test environments (DSPX-3302)
dmihalcik-virtru 5c1e619
feat(otdf-local): self-provision keys + opentdf.yaml at instance init
dmihalcik-virtru ecb04e1
fix(otdf-local): translate scenario suite to pytest argv per actual s…
dmihalcik-virtru 0b41c21
style(otdf-local): apply ruff format
dmihalcik-virtru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
--instanceflag correctly updates the environment and clears the settings cache. However, theupcommand in this file (specifically at lines 192 and 225) still relies on staticPortsconstants for health checks and port resolution. This will cause health checks to fail when a non-default instance with a differentports_baseis active. Theupcommand should be updated to use the instance-awaresettings.get_kas_port(name)or theportproperty of the service instances, and it should iterate over the instances managed bykas_managerinstead ofPorts.all_kas_names().