Improve Benchmarking

[JohnReedV]

Description

This PR

• Modifies the benchmark flow so that only extrinsics that have drifted passed the threshold or have incorrect read/writes are updated rather than replacing the entire file and creating conflicts everywhere.

• Adds a lint to check for extrinsics with missing benchmarks

• Adds missing benchmarks

• fixes a bug where it would fail extrinsics where it shouldn't.

[github-actions]

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

Baseline scrutiny: established OpenTensor-associated contributor with repo write permission; no trusted-list Gittensor match found; branch apply-benchmark-to-only-bad-benches -> devnet-ready.

Reviewed the trusted instructions, prior Skeptic sticky, contributor signals, PR metadata, comments, changed-file list, and pre-fetched diff. The prior sticky contains no finding IDs to reconcile.

The PR does not modify .github/ai-review/*, .github/copilot-instructions.md, workflow files, or Cargo.lock. Cargo changes only adjust features on existing workspace dependencies. The diff is scoped to benchmark setup, generated/runtime weight updates with a spec_version bump, benchmark tooling, and a build-time local-source benchmark coverage warning. I did not find credential access, hidden network access, shell injection, supply-chain dependency introduction, origin/permission changes, unsafe runtime code, or a credible malicious patch path.

Findings

No findings.

Conclusion

No malicious intent or security vulnerability was found in the reviewed diff. Residual risk is limited to benchmark-tooling correctness and generated-weight accuracy, which do not cross the Skeptic security threshold here.

---

🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor UNKNOWN; author has write permission, @opentensor affiliation, and substantial recent subtensor contribution history, so calibration is established-contributor domain review.

PR body is concise but substantive enough to leave unchanged.

Spec version is bumped from 423 to 424 for the runtime/weight changes, and the PR has no no-spec-version-bump label.

Duplicate-work check: overlapping open PRs appear to share generated/runtime weight files as incidental overlap; their titles and branches indicate unrelated runtime or feature work, not duplicate benchmark tooling. I do not recommend closing this PR in favor of another.

Validation: bash -n scripts/benchmark_action.sh and git diff --check $(git merge-base origin/devnet-ready HEAD) HEAD passed. Targeted cargo test -p subtensor-linting require_extrinsic_benchmarks could not start because rustup attempted to write under read-only /home/runner/.rustup/tmp; no workspace auto-fixes were made.

Findings

No findings.

Conclusion

The PR keeps benchmark patch application scoped to comparator-reported drifted functions, adds missing benchmark coverage and lint wiring, and preserves the required runtime spec bump. I did not find a domain correctness issue that should block merge.

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍