fix:modify adapt nodejs to java create app

[zhangjuncao]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features
  • Newly created apps now default to an unpublished status, ensuring a consistent starting state.
• Refactor
  • Enhanced application stability by properly initializing configuration and state data, resulting in more consistent API responses.
• Chores
  • Adjusted the data storage configuration for historical version tracking to allow more flexible data handling.

[coderabbitai]

Walkthrough

This pull request modifies the database schema and updates related Java classes. The SQL script now allows null values for the platform_history_id column in the t_app table. In the App entity, several collection fields are now initialized to prevent null reference issues and two fields have been annotated for JSON mapping. Additionally, the createApp method in AppServiceImpl now sets the isPublish property to false before persisting a new app.

Changes

File(s)	Change Summary
app/.../resources/sql/mysql/create_all_tables_ddl_v1.mysql.sql	Removed the not null constraint from the platform_history_id column in the t_app table.
base/.../entity/App.java	Initialized Map and List fields (config, dataHandler, globalState, extendConfig, dataSourceGlobal) and added @JsonProperty annotations for platformId and imageUrl.
base/.../service/app/impl/AppServiceImpl.java	Modified the createApp method to set the isPublish property of the app to false before creating it in the database.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant AS as AppServiceImpl
    participant DB as Database

    U->>AS: Call createApp(app)
    AS-->>AS: Set isPublish = false
    AS->>DB: Persist app data
    DB-->>AS: Return success
    AS->>U: Return result with app

Loading

Suggested reviewers

• lu-yg

Poem

I'm a bunny hopping through the code,
Nibbling bugs as new defaults explode,
Fields now bloom with HashMaps in cheer,
And nulls are friendly here,
With SQL and Java in perfect mode,
I celebrate the changes with a joyful ode!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c78c61 and da55008.

📒 Files selected for processing (3)

• app/src/main/resources/sql/mysql/create_all_tables_ddl_v1.mysql.sql (1 hunks)
• base/src/main/java/com/tinyengine/it/model/entity/App.java (6 hunks)
• base/src/main/java/com/tinyengine/it/service/app/impl/AppServiceImpl.java (1 hunks)

🔇 Additional comments (6)

app/src/main/resources/sql/mysql/create_all_tables_ddl_v1.mysql.sql (1)

70-70: 🏁 Script executed:

#!/bin/bash
# Check for any existing null values in platform_history_id column
echo "Checking for null values in platform_history_id column..."
mysql -e "SELECT COUNT(*) as null_count FROM t_app WHERE platform_history_id IS NULL;"

# Check for foreign key constraints referencing platform_history_id
echo "Checking for foreign key constraints..."
mysql -e "SELECT TABLE_NAME, COLUMN_NAME, CONSTRAINT_NAME, REFERENCED_TABLE_NAME, REFERENCED_COLUMN_NAME 
FROM INFORMATION_SCHEMA.KEY_COLUMN_USAGE 
WHERE REFERENCED_TABLE_NAME = 't_app' 
AND REFERENCED_COLUMN_NAME = 'platform_history_id';"

Length of output: 748

base/src/main/java/com/tinyengine/it/model/entity/App.java (4)

27-28: LGTM! Required imports added for collection implementations.

---

52-53: LGTM! JSON property mapping added for platformId.

The @JsonProperty annotation ensures correct JSON serialization/deserialization.

---

68-69: LGTM! JSON property mapping added for imageUrl.

The @JsonProperty annotation ensures correct JSON serialization/deserialization.

---

89-89: LGTM! Collections initialized to prevent NullPointerException.

Good practice to initialize collection fields with empty collections rather than null:

• config = new HashMap<>()
• dataHandler = new HashMap<>()
• globalState = new ArrayList<>()
• extendConfig = new HashMap<>()
• dataSourceGlobal = new HashMap<>()

Also applies to: 96-96, 137-137, 144-144, 155-155

base/src/main/java/com/tinyengine/it/service/app/impl/AppServiceImpl.java (1)

188-188: LGTM! Setting default publish state.

Good practice to explicitly set isPublish to false when creating a new app, ensuring a consistent initial state.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.