You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
As Anne has pointed out there's an existing explainer. This should redirect from the old explainer and the old one should be moved, deleted or otherwise handled so we don't have two show up. Feel free to link back to the old one from the new one
As Anne has pointed out there's an existing explainer. This should redirect from the old explainer and the old one should be moved, deleted or otherwise handled so we don't have two show up. Feel free to link back to the old one from the new one
Let's keep and link to it, don't delete it but keep the same URL so that anyone that linked to the prior one it still functions as expected. There's valid research in the prior one that we should retain
@annevk@gregwhitworth@lukewarlow The new explainer links to the old one in the "Alternative proposal" section and in "Alternatives Considered." Please let me know if this is insufficient in any way. Also, the old explainer will stay at its current URL, no changes to it in this PR. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Switch Attribute Explainer