Add esp32egpio module - control ESPs GPIOS through EGPIO framework#1261
Draft
CrashOverride2 wants to merge 1 commit intoopenvehicles:masterfrom
Draft
Add esp32egpio module - control ESPs GPIOS through EGPIO framework#1261CrashOverride2 wants to merge 1 commit intoopenvehicles:masterfrom
CrashOverride2 wants to merge 1 commit intoopenvehicles:masterfrom
Conversation
Member
|
LGTM. Only thing I'd recommend is to assert at most one of the two EGPIO modules is enabled, to assist users configuring their own build. I think the |
Contributor
Author
|
The idea of switching the GPIO framework is an even better one. I will definitely take a look at it so that it becomes easier and more logical for the user to configure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new esp32egpio module to control the ESP32’s native GPIOs using the existing, well-integrated, and easy-to-use EGPIO framework.
This is primarily intended for external OVMS-based modules and serves as an addendum to @zbchristian’s work.
It has been running flawlessly to control an additional heater in a friend’s car, and I thought it might be useful for the project as well.