Remove compound name parsing, store members in data#242
Draft
bkeepers wants to merge 6 commits intocompound-name-parsing-fixesfrom
Draft
Remove compound name parsing, store members in data#242bkeepers wants to merge 6 commits intocompound-name-parsing-fixesfrom
bkeepers wants to merge 6 commits intocompound-name-parsing-fixesfrom
Conversation
It was negated in original neaps implementation, and that was preserved when adopting the IHO implementation.
…ent naming errors
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bkeepers
force-pushed
the
compound-name-parsing-fixes
branch
from
8518a94 to
5b6636f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm about 4 cans of worms deep into changing how neaps stores and interprets constituent definitions. This is a followup to #240 to explore changing the constituent definitions in
data.jsonto store raw Doodson coefficients directly, with an optional human-readable XDO string for cross-referencing, and pre-compute all compound member decompositions. It removes thenodalCorrectionletter code entirely, replacing it with explicitmembersin the data. This eliminates the need for the Annex B name parser and theresolveMembers()function at runtime.I'm just going to open this and let it sit for a while and think about it. This current implementation is also blocked by #241. It could be unblocked by rebasing on master and switching the implementation of coefficient parsing back to the Schureman convention.