Rel pg 2.14#364
Merged
Merged
Conversation
allow omission of height from image subroutine and preserve aspect ratio
Fix problem with using identity matrix as a constant
Add missing parentheses around vectors in IJK mode.
Use proper closing markers for inequalities using 'and x != ...'
Purpose: In HTML pages with global dir="rtl" setting (for instance in an arabic or hebrew environment) one may still want mathematical formulas to be printed from left to right.
…rue for simplified ones.
Adjust simplified polynomial error messages
This assures that the direction is automatically detected. In a global RTL setting entering ASCII characters should lead to a LTR direction. If entering characters in languages that are traditionally written in the RTL direction, the direction should be RTL. See also: https://www.w3schools.com/tags/att_global_dir.asp An alternative setting would be "ltr" for the moment, since most input will be left to right. But this would probably lead to problem in case of problems that require the student to write down a proof or some other form of "free text" in languages that are written from right to left. So I propose the "auto" setting.
…ue if it is already a Real or Complex number.
Fix checks for scalar multiplication to not have to stringify the val…
…o x^(-a) for any constant power
mgage
requested review from
apizer,
aubreyja,
catatonicprime,
djun-kim,
dlglin,
dpvc,
drjt,
dsteinmo,
glarose,
goehle,
jwj61,
paultpearson,
pstaabp,
whytheplatypus and
xcompass
Make sure saved correct answer has units in NumberWithUnits()
Fix crash when preformatted text is used in a list
Member
|
Hi Mike,
I didn't look through the code, but what I see in this looks reasonable.
Gavin
…On Sat, Jul 21, 2018 at 12:11:21PM -0700, Michael Gage wrote:
@mgage requested your review on: openwebwork/pg#364 Rel pg 2.14.
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
#364 (comment)
--
--
P. Gavin LaRose | glarose@umich.edu | 734.764.7454 | EH 3832
Karen Rhea Collegiate Lecturer & Instructional Technology Program Manager
University of Michigan Department of Mathematics
|
PG-2.14 test -- fix one bug and update copyright
…rvers have changed.
Replace references to hosted2 with references to demo now that the se…
Member
|
@mgage The I noticed this issue as it was changed in the See: https://github.com/openwebwork/pg/blob/rel-PG-2.14/macros/PG.pl |
Member
Author
|
There are no outstanding pull requests to PG-2.14. I'll merge this into master. All further commits, except for urgent hotfixes will be made to the develop branch and be released generally in the next regular release of webwork2 and pg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not pull this into master yet. It gives a list of changes from rel-PG-2.13 and rel-PG-2.14