Skip to content

Devel candidate 01 27 2019 no multilingual changes#394

Merged
mgage merged 66 commits into
openwebwork:developfrom
mgage:devel_candidate_01_27_no_multilingual_changes
Mar 10, 2019
Merged

Devel candidate 01 27 2019 no multilingual changes#394
mgage merged 66 commits into
openwebwork:developfrom
mgage:devel_candidate_01_27_no_multilingual_changes

Conversation

@mgage
Copy link
Copy Markdown
Member

@mgage mgage commented Jan 28, 2019

This contains the commits that do not directly affect multilingual capabilities. I.e. there are no (new) references to utf8 or UTF-8. There have been some references to utf8 in develop (and master) for some time but with the multilingual pull request #390 we hope to unify and complete these references so that the code will work with all character sets.

In order to facilitate testing I have removed all (I think) changes which involved utf8 from #390
and placed them in this pull requests.

The two pull requests should now be independent of each other.

mgage and others added 30 commits January 27, 2019 21:31
…ableau.pl.

Add unit tests for tableau.pl and PGmatrixmacros.pl placed in t/matrix_ops
…s, to match the top_lables that already existed)
…l file.

Upload linebreak_at_commas_example.pg file
Fix problem if slice was not defined — provide a default of the entire width/height of the matrix
Improve documentation in tableau.pl
…(by introducing || clause).

It shouldn’t have been mysterious but it was.  Fixed it by using a less clever unless clause.

Added more guts to print_tableau_Test.pg.

At this point tableau.pl needs a _lot_ of refactoring and the test problems need work. Still don’t have an honest to goodness test example that is automated.  tableau.pl would be a good place to start.
The perl idiom $slice = @_ ||(1..5);   evaluates @_ in scalar context -- which is not what you want.
… not stringified for perl) HACK!!

for now this is just a hack.  Adding --http1.1 to the curl command to force HTTP/1.1 works on some machines
but not all.  The method for handling HTTP/2 forms is hackish at best.
Deduce answer number automatically, as well as row and column numbers
…e not read twice

Have quickMatrixEntry automatically execute INITIALIZE_QUICK_MATRIX_ENTRY() which inserts javaScript code in the html page. This does not have to be done twice, even if there are many problems using quick entry on the page.
also comment out some console.log reports
also add commands that ignore extraneous white space.
Add new permutation `contextPermutationUBC.pl` which differs from `contextPermutation.pl` by
- perform permutation multiplication
- allow displaying results in cycle, one line, or two line notation
- parses both cycle and one notations (one line uses [] and is converted to cycles internally)
Note: that these changes are in their own seperate file as the changes may break existing usages of `contextPermutation.pl`
- Limits input to Integer values
- Adds several integer functions for problem creation (phi, tau, lcm, gcd, isPrime, primeFactorization, randomPrime)
- Adds a helper function for creating congruence solutions
- reuses context Integer functions
- Options to accept general solution only, all solutions only, or both
It was failing. It doesn't appear to
be necessary in any case -- I'm not sure why it was working before.
Apparently a Value::Matrix is not a Parser::Item, nor does it need to be one
mgage and others added 27 commits February 24, 2019 13:28
…(by introducing || clause).

It shouldn’t have been mysterious but it was.  Fixed it by using a less clever unless clause.

Added more guts to print_tableau_Test.pg.

At this point tableau.pl needs a _lot_ of refactoring and the test problems need work. Still don’t have an honest to goodness test example that is automated.  tableau.pl would be a good place to start.
The perl idiom $slice = @_ ||(1..5);   evaluates @_ in scalar context -- which is not what you want.
… not stringified for perl) HACK!!

for now this is just a hack.  Adding --http1.1 to the curl command to force HTTP/1.1 works on some machines
but not all.  The method for handling HTTP/2 forms is hackish at best.
Deduce answer number automatically, as well as row and column numbers
…e not read twice

Have quickMatrixEntry automatically execute INITIALIZE_QUICK_MATRIX_ENTRY() which inserts javaScript code in the html page. This does not have to be done twice, even if there are many problems using quick entry on the page.
also comment out some console.log reports
also add commands that ignore extraneous white space.
Add new permutation `contextPermutationUBC.pl` which differs from `contextPermutation.pl` by
- perform permutation multiplication
- allow displaying results in cycle, one line, or two line notation
- parses both cycle and one notations (one line uses [] and is converted to cycles internally)
Note: that these changes are in their own seperate file as the changes may break existing usages of `contextPermutation.pl`
- Limits input to Integer values
- Adds several integer functions for problem creation (phi, tau, lcm, gcd, isPrime, primeFactorization, randomPrime)
- Adds a helper function for creating congruence solutions
- reuses context Integer functions
- Options to accept general solution only, all solutions only, or both
It was failing. It doesn't appear to
be necessary in any case -- I'm not sure why it was working before.
Apparently a Value::Matrix is not a Parser::Item, nor does it need to be one
(the template/macros files of courses using experimental versions of tableau
@mgage
Copy link
Copy Markdown
Member Author

mgage commented Mar 10, 2019

I let these changes accumulate for longer than I should have. This commit is larger than usual. There remain annoying issues with matrices/tableaus which should be resolved. Some of the functions added in tableau.pl and also other .pl files involving matrices should probably be moved into Value::Matrix -- but that can be done later.

@mgage mgage merged commit 18cfd60 into openwebwork:develop Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants