Devel candidate 01 27 2019 no multilingual changes#394
Merged
mgage merged 66 commits intoMar 10, 2019
Merged
Conversation
…ableau.pl. Add unit tests for tableau.pl and PGmatrixmacros.pl placed in t/matrix_ops
…s, to match the top_lables that already existed)
…l file. Upload linebreak_at_commas_example.pg file Fix problem if slice was not defined — provide a default of the entire width/height of the matrix Improve documentation in tableau.pl
…(by introducing || clause). It shouldn’t have been mysterious but it was. Fixed it by using a less clever unless clause. Added more guts to print_tableau_Test.pg. At this point tableau.pl needs a _lot_ of refactoring and the test problems need work. Still don’t have an honest to goodness test example that is automated. tableau.pl would be a good place to start.
The perl idiom $slice = @_ ||(1..5); evaluates @_ in scalar context -- which is not what you want.
… not stringified for perl) HACK!! for now this is just a hack. Adding --http1.1 to the curl command to force HTTP/1.1 works on some machines but not all. The method for handling HTTP/2 forms is hackish at best.
Deduce answer number automatically, as well as row and column numbers
…e not read twice Have quickMatrixEntry automatically execute INITIALIZE_QUICK_MATRIX_ENTRY() which inserts javaScript code in the html page. This does not have to be done twice, even if there are many problems using quick entry on the page.
also comment out some console.log reports also add commands that ignore extraneous white space.
Add new permutation `contextPermutationUBC.pl` which differs from `contextPermutation.pl` by - perform permutation multiplication - allow displaying results in cycle, one line, or two line notation - parses both cycle and one notations (one line uses [] and is converted to cycles internally) Note: that these changes are in their own seperate file as the changes may break existing usages of `contextPermutation.pl`
- Limits input to Integer values - Adds several integer functions for problem creation (phi, tau, lcm, gcd, isPrime, primeFactorization, randomPrime)
- Adds a helper function for creating congruence solutions - reuses context Integer functions - Options to accept general solution only, all solutions only, or both
It was failing. It doesn't appear to be necessary in any case -- I'm not sure why it was working before. Apparently a Value::Matrix is not a Parser::Item, nor does it need to be one
This seems to be a more advanced version.
…(by introducing || clause). It shouldn’t have been mysterious but it was. Fixed it by using a less clever unless clause. Added more guts to print_tableau_Test.pg. At this point tableau.pl needs a _lot_ of refactoring and the test problems need work. Still don’t have an honest to goodness test example that is automated. tableau.pl would be a good place to start.
The perl idiom $slice = @_ ||(1..5); evaluates @_ in scalar context -- which is not what you want.
… not stringified for perl) HACK!! for now this is just a hack. Adding --http1.1 to the curl command to force HTTP/1.1 works on some machines but not all. The method for handling HTTP/2 forms is hackish at best.
Deduce answer number automatically, as well as row and column numbers
…e not read twice Have quickMatrixEntry automatically execute INITIALIZE_QUICK_MATRIX_ENTRY() which inserts javaScript code in the html page. This does not have to be done twice, even if there are many problems using quick entry on the page.
also comment out some console.log reports also add commands that ignore extraneous white space.
Add new permutation `contextPermutationUBC.pl` which differs from `contextPermutation.pl` by - perform permutation multiplication - allow displaying results in cycle, one line, or two line notation - parses both cycle and one notations (one line uses [] and is converted to cycles internally) Note: that these changes are in their own seperate file as the changes may break existing usages of `contextPermutation.pl`
- Limits input to Integer values - Adds several integer functions for problem creation (phi, tau, lcm, gcd, isPrime, primeFactorization, randomPrime)
- Adds a helper function for creating congruence solutions - reuses context Integer functions - Options to accept general solution only, all solutions only, or both
It was failing. It doesn't appear to be necessary in any case -- I'm not sure why it was working before. Apparently a Value::Matrix is not a Parser::Item, nor does it need to be one
This seems to be a more advanced version.
(the template/macros files of courses using experimental versions of tableau
…://github.com/mgage/pg into devel_candidate_01_27_no_multilingual_changes
Member
Author
|
I let these changes accumulate for longer than I should have. This commit is larger than usual. There remain annoying issues with matrices/tableaus which should be resolved. Some of the functions added in tableau.pl and also other .pl files involving matrices should probably be moved into Value::Matrix -- but that can be done later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains the commits that do not directly affect multilingual capabilities. I.e. there are no (new) references to utf8 or UTF-8. There have been some references to utf8 in develop (and master) for some time but with the multilingual pull request #390 we hope to unify and complete these references so that the code will work with all character sets.
In order to facilitate testing I have removed all (I think) changes which involved utf8 from #390
and placed them in this pull requests.
The two pull requests should now be independent of each other.