Add support for Bun#249
Merged
jamescmartinez merged 3 commits intomainfrom Feb 4, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR adds Bun runtime support to OpenWorkflow's SQLite backend, making OpenWorkflow compatible with both Node.js and Bun. The changes introduce runtime detection to dynamically load either node:sqlite (for Node.js) or bun:sqlite (for Bun), along with a common Database interface that both drivers satisfy.
Changes:
- Introduced runtime detection to support both Node.js (
node:sqlite) and Bun (bun:sqlite) for SQLite operations - Defined a common Database interface that abstracts the differences between the two SQLite implementations
- Simplified type casting in backend.ts by removing unnecessary double casts
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/openworkflow/sqlite/sqlite.ts | Added runtime detection logic, Database interface abstraction, and dynamic require() for node:sqlite vs bun:sqlite |
| packages/openworkflow/sqlite/backend.ts | Simplified type casting from row as unknown as Type to row as Type for better readability |
Contributor
Author
|
this had to be reverted in 5d6c607 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #247
Summary
Adds SQLite support for Bun, which makes OpenWorkflow Bun-compatible 🎊