Skip to content

test: increase timeouts for flaky time-based tests#471

Merged
jamescmartinez merged 1 commit intomainfrom
flaky-tests
Apr 17, 2026
Merged

test: increase timeouts for flaky time-based tests#471
jamescmartinez merged 1 commit intomainfrom
flaky-tests

Conversation

@jamescmartinez
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 17, 2026 03:28
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 17, 2026

Open in StackBlitz

npm i https://pkg.pr.new/openworkflowdev/openworkflow/@openworkflow/cli@471
npm i https://pkg.pr.new/openworkflowdev/openworkflow/@openworkflow/dashboard@471
npm i https://pkg.pr.new/openworkflowdev/openworkflow@471

commit: 7d42320

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces flakiness in OpenWorkflow’s time-sensitive worker/backend test suite by increasing per-test timeouts and widening timing buffers (sleep durations and wait periods).

Changes:

  • Adds explicit per-test timeouts for longer-running/flaky tests.
  • Increases various sleep(...) waits used to allow async worker ticks to settle.
  • Adjusts a few timing assertions/limits to tolerate slower CI environments.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/openworkflow/worker/worker.test.ts Adds per-test timeouts and increases wait/sleep durations in worker timing tests to reduce flake.
packages/openworkflow/worker/execution.test.ts Increases settle waits; adds longer per-test timeouts for high-parallelism fan-out tests; de-dupes step-name collection to avoid replay/duplicate-attempt noise.
packages/openworkflow/testing/backend.testsuite.ts Adds a longer timeout for a concurrency-heavy idempotency test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jamescmartinez jamescmartinez merged commit e122325 into main Apr 17, 2026
14 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants