chore: switch to mise for dev environment#497
Conversation
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Switches the repo’s dev/CI toolchain provisioning from actions/setup-node / setup-bun to mise, aiming to standardize Node/Bun versions across contributors and GitHub Actions.
Changes:
- Add
mise.tomldefining Node/Bun tool versions. - Update GitHub Actions workflows to use
jdx/mise-action@v2instead ofactions/setup-nodeandsetup-bun. - Update contributing docs to describe the new mise-based setup; remove root
package.jsonengines.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removes engines (keeps packageManager). |
| mise.toml | Introduces mise tool version configuration for Node/Bun. |
| CONTRIBUTING.md | Documents mise-based dev environment setup. |
| .github/workflows/pkg-pr-new.yaml | Switches workflow tool setup to jdx/mise-action@v2. |
| .github/workflows/ci.yaml | Switches CI (Node + Bun jobs, commitlint) tool setup to jdx/mise-action@v2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "node": ">=22.5.0", | ||
| "npm": ">=11" | ||
| } | ||
| "packageManager": "npm@11.8.0" |
There was a problem hiding this comment.
.npmrc has engine-strict=true, but this PR removes the engines field. With no engines, npm won’t enforce Node/npm versions, which can lead to contributors (or CI runners) using unsupported runtimes without an explicit failure. Consider restoring engines (even if you also use mise) or removing engine-strict if the intent is to rely solely on mise for version enforcement.
No description provided.