luci-app-photonicat: add support for Ariaboard Photonicat 2#8483
Open
th3cavalry wants to merge 1 commit intoopenwrt:masterfrom
Open
luci-app-photonicat: add support for Ariaboard Photonicat 2#8483th3cavalry wants to merge 1 commit intoopenwrt:masterfrom
th3cavalry wants to merge 1 commit intoopenwrt:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
systemcrash
reviewed
Mar 29, 2026
| LUCI_PKGARCH:=all | ||
|
|
||
| PKG_LICENSE:=GPL-2.0 | ||
| PKG_MAINTAINER:=Brandon Cleary <cleary.brandon@gmail.com> |
Contributor
There was a problem hiding this comment.
Use this for the commit SoB and commit author.
systemcrash
reviewed
Mar 29, 2026
Contributor
There was a problem hiding this comment.
The init and sbin should go in the other repo.
systemcrash
reviewed
Mar 29, 2026
| 'require poll'; | ||
| 'require dom'; | ||
|
|
||
| var callGetStatus = rpc.declare({ |
Contributor
There was a problem hiding this comment.
Use ES2016 - const and let throughout.
th3cavalry
force-pushed
the
add-luci-app-photonicat
branch
2 times, most recently
from
8f55ae4 to
e933e13
Compare
Address review feedback from systemcrash: - Modernize JavaScript to ES2016 (use const/let instead of var). - Remove hardware-specific fan control scripts (moved to core repo). Signed-off-by: Brandon Cleary <cleary.brandon@gmail.com>
th3cavalry
force-pushed
the
add-luci-app-photonicat
branch
from
e933e13 to
3950b54
Compare
Author
|
Thank you for the review! I have addressed your suggestions:
The LuCI PR is now focused strictly on the web interface components. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the Ariaboard Photonicat 2 system dashboard and fan control.
This application provides:
photonicat-fan) with auto/manual modespcat2-mcuubus APINOTE: This package depends on
pcat2-mcu, which is part of the core device support PR: openwrt/openwrt#22246.