Skip to content

luci-mod-network: add qdisc option to device settings#8498

Open
owldev127 wants to merge 1 commit intoopenwrt:masterfrom
owldev127:feature_qdisc_device_config
Open

luci-mod-network: add qdisc option to device settings#8498
owldev127 wants to merge 1 commit intoopenwrt:masterfrom
owldev127:feature_qdisc_device_config

Conversation

@owldev127
Copy link
Copy Markdown

Expose the per-device qdisc option in the network device configuration form so queueing disciplines can be configured through LuCI.

Ref: #8475

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile
  • Tested on: (architecture, openwrt version, browser) ✅
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: e.g. openwrt/luci#issue-number
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: (describe the changes proposed in this PR)

Expose the per-device qdisc option in the network device configuration form so queueing disciplines can be configured through LuCI.

Ref: openwrt#8475
Signed-off-by: Jordan <jfun99305@gmail.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Warning

Some formality checks failed.

Consider (re)reading submissions guidelines.

Failed checks

Issues marked with an ❌ are failing checks.

Commit b4441e3

  • 🔶 Author name must be either a real name 'firstname lastname' or a nickname/alias/handle
    Actual: Jordan seems to be a nickname or an alias
    Expected: a real name 'firstname lastname'
  • 🔶 Commit(ter) name must be either a real name 'firstname lastname' or a nickname/alias/handle
    Actual: Jordan seems to be a nickname or an alias
    Expected: a real name 'firstname lastname'
  • 🔶 Commit message lines should be <= 75 characters long
    Actual: line 2 is 131 characters long
    $\textsf{Expose the per-device qdisc option in the network device configuration form\color{red}{ so queueing disciplines can be configured through LuCI.}}$

For more details, see the full job log.

Something broken? Consider providing feedback.

@systemcrash
Copy link
Copy Markdown
Contributor

Which daemon or program consumes the qdisc setting?

@owldev127
Copy link
Copy Markdown
Author

owldev127 commented Apr 3, 2026

@systemcrash
netifd problem consumes qdisc setting so I think we have to update it in backend side to support qdisc setting. Do you agree?

@systemcrash
Copy link
Copy Markdown
Contributor

I don't see any mentions of qdisc in netifd source. Is this in some helper script?

@owldev127
Copy link
Copy Markdown
Author

I don't see any mentions of qdisc in netifd source. Is this in some helper script?

Yes, I noticed that we need to ask them to add qdisc too. This feature request got a bit complicated.

@owldev127
Copy link
Copy Markdown
Author

Can you ask them to add qdisc setting support?

@systemcrash
Copy link
Copy Markdown
Contributor

You can ask. I don't use QoS or prioritising, so I don't know what it should do. In any case, this changeis effectively meaningless until the back-end understands what to do with qdisc.

@owldev127
Copy link
Copy Markdown
Author

Yes, I'll try to ask them for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants