Skip to content

luci-theme-material: refining hide/show buttons#8512

Closed
owlsy wants to merge 2 commits intoopenwrt:masterfrom
owlsy:luci-theme-material-hide-show
Closed

luci-theme-material: refining hide/show buttons#8512
owlsy wants to merge 2 commits intoopenwrt:masterfrom
owlsy:luci-theme-material-hide-show

Conversation

@owlsy
Copy link
Copy Markdown
Contributor

@owlsy owlsy commented Apr 2, 2026

Changes

  • Change mouse icon on hide/show button from a text cursor to a pointer.
  • Fix the hide/show buttons not being the same min-width due to text being different sizes.
  • Create larger hide/show buttons for smaller screens, for the same behaviour as luci-theme-bootstrap.
  • Slightly fade "show" button: no variable for disabled opacity like luci-theme-bootstrap, assuming 0.7.
  • Remove that fade when hovering over the button.

Notes

Checklist

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile
  • Tested on: (architecture, openwrt version, browser) ✅
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
  • Description: (describe the changes proposed in this PR)

Change mouse icon from text cursor to pointer.
Fix buttons not being same min-width.
Create larger buttons for smaller screens,
same behaviour as luci-theme-bootstrap.
Slightly fade "show" button:
no variable for disabled opacity
like luci-theme-bootstrap,
assuming 0.7.
Remove fade when hovered.

Signed-off-by: Joshua Criss <owlsy@outlook.com.au>
Signed-off-by: Owl <owlsy@outlook.com.au>
@owlsy
Copy link
Copy Markdown
Contributor Author

owlsy commented Apr 2, 2026

Should I wait for #8508 before rebasing on master and updating this pull request?

Edit: Just going to make a new pull request as I can't remove the latest merge commit, I had trouble figuring it out without making more of a mess.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Warning

Some formality checks failed.

Consider (re)reading submissions guidelines.

Failed checks

Issues marked with an ❌ are failing checks.

Commit a8d6ecd

  • ❌ Pull request must not include merge commits

For more details, see the full job log.

Something broken? Consider providing feedback.

@owlsy owlsy marked this pull request as draft April 2, 2026 22:47
@owlsy owlsy closed this Apr 2, 2026
@owlsy
Copy link
Copy Markdown
Contributor Author

owlsy commented Apr 2, 2026

Messed up the commits and couldn't resolve it. Closing and trying again with #8519.

@owlsy owlsy deleted the luci-theme-material-hide-show branch April 2, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant