validators: warn on feed packages forcing DEFAULT via BUILDBOT - #59
Open
BKPepe wants to merge 1 commit into
Open
validators: warn on feed packages forcing DEFAULT via BUILDBOT#59BKPepe wants to merge 1 commit into
BKPepe wants to merge 1 commit into
Conversation
A package's own Makefile can pull itself into buildbot default images by conditioning DEFAULT on BUILDBOT (e.g. openwrt/packages#29022, openwrt/packages' utils/owut/Makefile), bypassing the main openwrt/openwrt repo's own default-package process entirely. See issue #4. Add check_buildbot_default (default: warning) to flag newly added DEFAULT lines conditioned on BUILDBOT inside feed Makefiles. Plain DEFAULT:=y (not gated on BUILDBOT) is left alone since that's a normal, legitimate use of the variable. The check is skipped for the main openwrt/openwrt repo, where this is the intended mechanism, and only looks at added lines so pre-existing occurrences like owut's aren't retroactively flagged. Fixes: #4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A package's own Makefile can pull itself into buildbot default images by conditioning DEFAULT on BUILDBOT (e.g. openwrt/packages#29022, openwrt/packages' utils/owut/Makefile), bypassing the main openwrt/openwrt repo's own default-package process entirely. See issue #4.
Add check_buildbot_default (default: warning) to flag newly added DEFAULT lines conditioned on BUILDBOT inside feed Makefiles. Plain DEFAULT:=y (not gated on BUILDBOT) is left alone since that's a normal, legitimate use of the variable. The check is skipped for the main openwrt/openwrt repo, where this is the intended mechanism, and only looks at added lines so pre-existing occurrences like owut's aren't retroactively flagged.
Fixes: #4