validators: skip committer identity checks for GitHub web UI commits - #69
Merged
Conversation
BKPepe
force-pushed
the
fix-github-web-commit-validation
branch
from
July 26, 2026 07:14
867d80c to
47db109
Compare
Commits made through GitHub's web interface (file editor, "Commit suggestion", "Update branch") are committed as `GitHub <noreply@github.com>` on the user's behalf. The committer name check rejects that as an invalid full name, which the contributor has no way to fix. Recognize such commits and skip the committer name and email checks for them, while every author identity check stays in place. A Signed-off-by can then only match the author, so the error no longer offers signing off as the committer. The commit is recognized by the `web-flow` account GitHub resolves the committer to, which a local git config cannot claim, with the literal `GitHub <noreply@github.com>` identity as a fallback. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
BKPepe
force-pushed
the
fix-github-web-commit-validation
branch
from
July 26, 2026 07:24
47db109 to
534b7c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a commit is created via GitHub's web interface, the committer is automatically set to 'GitHub noreply@github.com' by GitHub itself. This is not under the user's control and was causing false positives in the committer name and noreply email validation checks.
Detect this pattern and skip committer-specific validation (name format and noreply email) while still enforcing all author identity checks. In Signed-off-by matching, only check against the author identity for web commits since the committer identity is always GitHub's.