ddns-scripts: update hotplug to handle ip address changing by ifupdate#28546
ddns-scripts: update hotplug to handle ip address changing by ifupdate#28546sunnyqeen wants to merge 1 commit intoopenwrt:masterfrom
Conversation
|
Can you please add the comment from the PR to the commit. Then we know why we have added this. |
|
@feckert thanks, commit changed. |
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue where DDNS scripts fail to update when an IPv6 address changes dynamically on an interface. The fix adds handling for the ifupdate hotplug action to restart DDNS services when IP addresses change, preventing the script from entering a dead loop attempting to use an outdated IPv6 address.
Changes:
- Added
ifupdateaction handler to restart DDNS service when interface addresses change - Updated comment to remove specific reference to
ifupdateas an unneeded action - Bumped package release version from 91 to 92
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| net/ddns-scripts/files/etc/hotplug.d/iface/ddns | Added ifupdate case handler to stop and restart DDNS when addresses change |
| net/ddns-scripts/Makefile | Incremented PKG_RELEASE version for the new functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
CI/CD ist not happy https://github.com/openwrt/packages/actions/runs/21918443767/job/63495807196?pr=28546 pleas update the commit description |
To handle ip address changing by ifupdate. When the ipv6 address is updated for an interface (some ISP only give dynamic ipv6 address). The ddns script will go into dead loop, as the new ipv6 address is not used. The simple change is restarting ddns when ip address is changed. Signed-off-by: Jimmy Qin <sunnyqeen@gmail.com>
2 participants
Description:
When the ipv6 address is updated for an interface. (some ISP only give dynamic ipv6 address)
The ddns script will go into dead loop, as the new ipv6 address is not used.
The simple change is restarting ddns when ip address is changed.
see the log below
180654 : #> /usr/bin/wget --hsts-file=/tmp/.wget-hsts -nv -t 1 -O /var/run/ddns/myddns_ipv6.dat -o /var/run/ddns/myddns_ipv6.err --bind-address=0000:0000:0000:0000::1 --no-proxy 'https://update.dedyn.io/update?username=*&password=***PW***&hostname=*&myipv6=0000:0000:0000:0000:0000:0000:0000:0001&myipv4=preserve' 180654 ERROR : GNU Wget Error: '4' 180654 : failed: Address not available. failed: Address family not supported by protocol. 180654 WARN : Transfer failed - retry 4914/0 in 60 seconds