-
Notifications
You must be signed in to change notification settings - Fork 3.9k
openvpn: cleanup Makefile #28679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
openvpn: cleanup Makefile #28679
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3bb443d
openvpn: refactoring INSTALL_DIR command call during install
feckert 5831202
openvpn: remove not needed INSTALL_DIR creations
feckert 3339a8e
openvpn: improve readability for files install target
feckert 60816bc
openvpn: move lib/upgrade/keep.d file into its own dir
feckert 5eb12bc
openvpn: move usr/share/openvpn files into its own dir
feckert 0ee8b3a
openvpn: increment PKG_RELEASE by one
feckert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Florian, we are having a similar discussion here: #30010 (comment)
Could you please also check if conffiles will work for you? I took a look at the repository, and basically, you are the only one using keep.d in this specific way :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is working as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, now I get what you mean. I need to add that to the "conffiles" target in the Makefile.
Wait, I'll have to take a look at that and run a build first.
I'll get back to you in a few days.