Skip to content

transmission: grant r/w access to config dir#29858

Open
lolomokakus wants to merge 1 commit into
openwrt:masterfrom
lolomokakus:transmission_cfgdir
Open

transmission: grant r/w access to config dir#29858
lolomokakus wants to merge 1 commit into
openwrt:masterfrom
lolomokakus:transmission_cfgdir

Conversation

@lolomokakus

Copy link
Copy Markdown

📦 Package Details

Maintainer: @dangowrt

Description:
Transmission seems to expect to have read/write access to its config directory. When it tries to update a file there, for example stats.json, it first creates a temporary file (like stats.json.tmp.xxxxxx) and then moves it into the proper place. However, with the current ujail configuration, this fails: stats.json does not get updated and the temp file is not removed. With a long-running transmission daemon, this makes the config directory fill up with stale temp files.

This PR grants the daemon write permission to files in the config directory except for settings.json. This makes file updates work and drastically reduces the amount of temp files lying around. The daemon still creates some when it occasionally tries and fails to write to settings.json (probably only on startup/shutdown). This seems to happen at a much lower rate than other writes though, and this way the settings file is kept in sync with UCI at all times.


🧪 Run Testing Details

  • OpenWrt Version: 25.12.4
  • OpenWrt Target/Subtarget: mediatek/filogic
  • OpenWrt Device: asus_rt-ax59u

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit; no new issues found.


Generated by Claude Code

@BKPepe
BKPepe force-pushed the transmission_cfgdir branch from 3c59a01 to 10bfdb0 Compare July 19, 2026 10:59
Solves issues with stats etc. not updating properly and reduces the
amount of leftover temporary files. Access to settings.json is kept
read-only to keep it in sync with UCI.

Signed-off-by: Ludvig Liu Holtze <ldw.liu.holtze@proton.me>

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit; no new issues found.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants