procs: bump to 0.14.12#30016
Conversation
| nonnumeric_search = false | ||
| align = "Left" | ||
|
|
||
| [[columns]] |
There was a problem hiding this comment.
This was removed, but in the commit itself there is no mention about this.
There was a problem hiding this comment.
I just added a better description to the commit
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Commit checks
- 8d3ce09 "procs: bump to 0.14.12" — the message describes only a version bump, but the commit also removes a substantial amount of
procs.tomlconfiguration (aMultiSlotcolumn, several[display]options,case,theme, and the[pager]detect_width/use_builtinkeys) and changes the pager mode. None of that is mentioned in the message. Please document the config changes (and the reasoning) in the commit body — a maintainer already raised the same point inline. The body is also just a repeat of the subject line; use it to give context instead.
Generated by Claude Code
| detect_width = false | ||
| use_builtin = false | ||
|
|
||
| mode = "Auto" |
There was a problem hiding this comment.
The pager mode changes from "Disable" to "Auto". The removed line carried an OpenWrt-specific reason for disabling it: BusyBox less (the default on OpenWrt) does not support the -SR flags procs passes, and paging was intentionally disabled unless the full less package is installed. With "Auto", procs will invoke the pager on a stock install and paged output may break. Was this switch intentional / tested on a target with BusyBox less, or should it stay "Disable"? If intentional, please call it out in the commit message.
Generated by Claude Code
There was a problem hiding this comment.
Just pushed a fix, it has to be kept as Disabled
8d3ce09 to
238b84a
Compare
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Commit checks
- 238b84a "procs: bump to 0.14.12" — the pager
mode = "Disable"is now a deliberate OpenWrt-specific override (as the new inline comment explains), but the body still says the config was updated "to match default config file from upstream." Consider noting this intentional deviation in the message so it doesn't read as plain upstream parity. Thanks for restoringDisable— my earlier pager concern is resolved.
Generated by Claude Code
| @@ -133,6 +118,3 @@ path = "unix:///var/run/docker.sock" | |||
|
|
|||
| [pager] | |||
| mode = "Disable" # OpenWrt's less doen't support the flags '-SR', if needed install the full less pacakge | |||
There was a problem hiding this comment.
nit: two typos in this comment — doen't → doesn't and pacakge → package.
| mode = "Disable" # OpenWrt's less doen't support the flags '-SR', if needed install the full less pacakge | |
| mode = "Disable" # OpenWrt's less doesn't support the flags '-SR', if needed install the full less package |
Generated by Claude Code
There was a problem hiding this comment.
Changed the comment to a more assertive one
Updated procs package to 0.14.12 Updated procs.toml (config file) to match default config file from upstream Signed-off-by: Facundo Acevedo <facevedo@disroot.org>
238b84a to
d851cd3
Compare
3 participants
Updated procs package to 0.14.12
📦 Package Details
Maintainer: @FacundoAcevedo
(You can find this by checking the history of the package
Makefile.)Description:
Updates packages to v0.14.12
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.