zabbix: bring agent, server, and proxy to parity#30026
Open
danielfdickinson wants to merge 4 commits into
Open
zabbix: bring agent, server, and proxy to parity#30026danielfdickinson wants to merge 4 commits into
danielfdickinson wants to merge 4 commits into
Conversation
3 tasks
This is the upstream recommendation, and fits with our separation of agent and server. Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
Tweak the agentd and server patch configurations and bring agentd and server confgurations to parity. Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
danielfdickinson
force-pushed
the
pr-zabbix-bring-agent-server-proxy-to-parity
branch
from
July 18, 2026 12:20
11826d3 to
d4841fd
Compare
danielfdickinson
marked this pull request as draft
July 18, 2026 17:55
danielfdickinson
marked this pull request as ready for review
July 18, 2026 18:21
openwrt-ai
reviewed
Jul 19, 2026
openwrt-ai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 4 new commits; commit messages match their changes. One inline issue on the zabbix-agentd-basic conffiles/postinst references.
Generated by Claude Code
danielfdickinson
force-pushed
the
pr-zabbix-bring-agent-server-proxy-to-parity
branch
from
July 19, 2026 06:24
d4841fd to
5be382f
Compare
openwrt-ai
reviewed
Jul 20, 2026
openwrt-ai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 2 new commits; no new issues found. The previously flagged zabbix-agentd-basic conffiles/postinst references now correctly point to Package/zabbix-agentd/* (hyphen), matching the actual defines.
Generated by Claude Code
BKPepe
reviewed
Jul 20, 2026
* Genericize zabbix_server initscript. * Add shellcheck overrides where needed. * Add a 'never_root' config option (default true) that determines whether server starts as an unprivileged user or starts as root and drops to an unprivileged user (unless config is changed so it always runs as root). * Bring zabbix_agentd initscript to parity with zabbix_server for the initscript and configuration. * Tweak Makefile to reduce repetition Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
* Add config file patch for proxy * Add initscript for proxy * Update Makefile and support files to bring proxy to parity with agentd and server. Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
danielfdickinson
force-pushed
the
pr-zabbix-bring-agent-server-proxy-to-parity
branch
from
July 20, 2026 06:49
5be382f to
fb2e609
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @danielfdickinson
Description:
Splits out the main set of changes from #30010 because it is cleaner / better separation of concerns.
fits with our seperation of agent and server.
server confgurations to parity.
whether server starts as an unprivileged user or starts as root and
drops to an unprivileged user (unless config is changed so it always
runs as root).
initscript and configuration.
agentd and server.
and (after split)
✅ Formalities
If your PR contains a patch:
git amN/A: OpenWrt-specific configuration tweaks