Skip to content

zabbix: bring agent, server, and proxy to parity#30026

Open
danielfdickinson wants to merge 4 commits into
openwrt:masterfrom
danielfdickinson:pr-zabbix-bring-agent-server-proxy-to-parity
Open

zabbix: bring agent, server, and proxy to parity#30026
danielfdickinson wants to merge 4 commits into
openwrt:masterfrom
danielfdickinson:pr-zabbix-bring-agent-server-proxy-to-parity

Conversation

@danielfdickinson

@danielfdickinson danielfdickinson commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

📦 Package Details

Maintainer: @danielfdickinson

Description:
Splits out the main set of changes from #30010 because it is cleaner / better separation of concerns.

  • Use separate users for server and proxy. This is the upstream recommendation, and
    fits with our seperation of agent and server.
  • Tweak the agentd and server patch configuration and bring agentd and
    server confgurations to parity.
  • Tweak server initscript and bring agentd to parity
    • Genericize zabbix_server initscript.
    • Add shellcheck overrides where needed.
    • Add a 'never_root' config option (default true) that determines
      whether server starts as an unprivileged user or starts as root and
      drops to an unprivileged user (unless config is changed so it always
      runs as root).
    • Bring zabbix_agentd initscript to parity with zabbix_server for the
      initscript and configuration.
    • Tweak Makefile to reduce repetition
  • Bring proxy to parity with server and agentd
    • Add config file patch for proxy
    • Add initscript for proxy
    • Update Makefile and support files to bring proxy to parity with
      agentd and server.

  • OpenWrt Version: OpenWrt SNAPSHOT r35362-9e43544bc6
  • OpenWrt Target/Subtarget: bcm27xx/bcm2712
  • OpenWrt Device: Raspberry Pi 5 Model B Rev 1.0

and (after split)

  • OpenWrt Version: OpenWrt SNAPSHOT r35420-06c826e335
  • OpenWrt Target/Subtarget: mediatek/filogic
  • OpenWrt Device: OpenWrt One

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    N/A: OpenWrt-specific configuration tweaks

This is the upstream recommendation, and fits with our separation
of agent and server.

Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
Tweak the agentd and server patch configurations and bring agentd and
server confgurations to parity.

Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
@danielfdickinson
danielfdickinson force-pushed the pr-zabbix-bring-agent-server-proxy-to-parity branch from 11826d3 to d4841fd Compare July 18, 2026 12:20
@danielfdickinson
danielfdickinson marked this pull request as draft July 18, 2026 17:55
@danielfdickinson
danielfdickinson marked this pull request as ready for review July 18, 2026 18:21

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 new commits; commit messages match their changes. One inline issue on the zabbix-agentd-basic conffiles/postinst references.


Generated by Claude Code

Comment thread admin/zabbix/Makefile Outdated
@danielfdickinson
danielfdickinson force-pushed the pr-zabbix-bring-agent-server-proxy-to-parity branch from d4841fd to 5be382f Compare July 19, 2026 06:24

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 new commits; no new issues found. The previously flagged zabbix-agentd-basic conffiles/postinst references now correctly point to Package/zabbix-agentd/* (hyphen), matching the actual defines.


Generated by Claude Code

Comment thread admin/zabbix/files/zabbix_agentd.init Outdated
* Genericize zabbix_server initscript.
* Add shellcheck overrides where needed.
* Add a 'never_root' config option (default true) that determines
  whether server starts as an unprivileged user or starts as root and
  drops to an unprivileged user (unless config is changed so it always
  runs as root).
* Bring zabbix_agentd initscript to parity with zabbix_server for the
  initscript and configuration.
* Tweak Makefile to reduce repetition

Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
* Add config file patch for proxy
* Add initscript for proxy
* Update Makefile and support files to bring proxy to parity with
  agentd and server.

Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
@danielfdickinson
danielfdickinson force-pushed the pr-zabbix-bring-agent-server-proxy-to-parity branch from 5be382f to fb2e609 Compare July 20, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants