Skip to content

radsecproxy: add more config options for UCI#30044

Open
Janfred wants to merge 1 commit into
openwrt:masterfrom
Janfred:feature_radsecproxy
Open

radsecproxy: add more config options for UCI#30044
Janfred wants to merge 1 commit into
openwrt:masterfrom
Janfred:feature_radsecproxy

Conversation

@Janfred

@Janfred Janfred commented Jul 19, 2026

Copy link
Copy Markdown

📦 Package Details

Maintainer: @commodo

Description:
This patch adds additional configuration options that can come from the UCI config files.


🧪 Run Testing Details

  • OpenWrt Version: 25.12.5 r33051-f5dae5ece4
  • OpenWrt Target/Subtarget: ath79/generic
  • OpenWrt Device: TP-Link Archer C7 v5

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

@openwrt

openwrt Bot commented Jul 19, 2026

Copy link
Copy Markdown

Formality Check: Suggestions Available

We completed the verification flow. Please review the formatting overview logs below.

⚠️ STYLISTIC WARNINGS & SUGGESTIONS

Package Release Audit:

  • ⚠️ Package net/radsecproxy content changed without a PKG_RELEASE or version bump
  • Do not increment release for minor changes. Cosmetic edits (e.g., typos in comments, copyright updates, formatting/whitespace), changing the package maintainer (PKG_MAINTAINER), or updating source download info (PKG_SOURCE_URL / PKG_HASH) do not require incrementing PKG_RELEASE.

Something broken? Consider reporting an issue.
Running version 472f311 deployed on 2026-07-19 13:45:30 CEST

This adds more config options for use in UCI, esp. new configuration
options that were introduced in newer radsecproxy versions

Signed-off-by: Jan-Frederik Rieckers <rieckers@dfn.de>
@Janfred
Janfred force-pushed the feature_radsecproxy branch from f09a6a6 to 01223a0 Compare July 19, 2026 12:24
@Janfred Janfred changed the title WIP: radsecproxy: add more config options for UCI radsecproxy: add more config options for UCI Jul 19, 2026

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit. One inline note on package release hygiene; the commit message accurately describes the change.


Generated by Claude Code

Include host type secret tls matchCertificateAttribute duplicateInterval \
AddTTL fticksVISCOUNTRY fticksVISINST rewrite rewriteIn rewriteOut \
rewriteAttribute
rewriteAttribute serverName PSKkey PSKidentity

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds new UCI-driven directives to the installed /etc/init.d/radsecproxy script, which is a functional change to package contents. PKG_RELEASE in the Makefile should be incremented (2 → 3) so existing installs receive the rebuilt package on opkg upgrade. See net/radsecproxy/Makefile#L12. The bot's release-audit note applies here — this is not a cosmetic edit, so the "do not increment for minor changes" exception does not apply.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants