Skip to content

[Exch-13810] return buyer exts in response to dsp #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kacper Fus (Fuska1) wants to merge 14 commits into from
Closed

[Exch-13810] return buyer exts in response to dsp #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5ca444f
Return buyer exts in response to DSP
Fuska1 Aug 28, 2025
c67d07c
refactor
Fuska1 Aug 28, 2025
a4c4fc4
refactor
Fuska1 Aug 28, 2025
2b54e68
extract buyer ext from bid not seatBid
Fuska1 Aug 28, 2025
d840da6
refactor getBidMeta
Fuska1 Aug 29, 2025
285b879
fix setting meta parameters
Fuska1 Aug 29, 2025
c249393
test refactor
Fuska1 Aug 29, 2025
8aac64f
suggestions
Fuska1 Aug 29, 2025
1322c1b
refactor
Fuska1 Aug 29, 2025
264aed7
add empty string check
Fuska1 Aug 29, 2025
8cd070b
suggested refactor
Fuska1 Sep 1, 2025
880b7b8
Unmarshal DspID and BrandID to int
bukrain Sep 9, 2025
2bb4719
Refactor test to use json.RawMessage
bukrain Sep 9, 2025
5330f79
Add additional test cases
bukrain Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions adapters/openx/openx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"encoding/json"
"fmt"
"net/http"
"strconv"

"github.com/prebid/openrtb/v20/openrtb2"
"github.com/prebid/prebid-server/v3/adapters"
Expand Down Expand Up @@ -32,6 +33,12 @@ type openxRespExt struct {
FledgeAuctionConfigs map[string]json.RawMessage `json:"fledge_auction_configs,omitempty"`
}

type oxBidExt struct {
DspId int `json:"dsp_id,string,omitempty"`
BrandId int `json:"brand_id,string,omitempty"`
BuyerId string `json:"buyer_id,omitempty"`
}

func (a *OpenxAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {
var errs []error
var bannerAndNativeImps []openrtb2.Imp
Expand Down Expand Up @@ -238,6 +245,7 @@ func (a *OpenxAdapter) MakeBids(internalRequest *openrtb2.BidRequest, externalRe
Bid: &sb.Bid[i],
BidType: getBidType(sb.Bid[i].MType, sb.Bid[i].ImpID, internalRequest.Imp),
BidVideo: getBidVideo(&sb.Bid[i]),
BidMeta: getBidMeta(&sb.Bid[i]),
})
}
}
Expand Down Expand Up @@ -298,3 +306,36 @@ func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server co
}
return bidder, nil
}

func getBidMeta(bid *openrtb2.Bid) *openrtb_ext.ExtBidPrebidMeta {
if bid.Ext == nil {
return nil
}

var ext *oxBidExt
if err := jsonutil.Unmarshal(bid.Ext, &ext); err != nil {
return nil
}

buyerId := getBuyerIdFromExt(ext)
if buyerId <= 0 && ext.DspId <= 0 && ext.BrandId <= 0 {
return nil
}

return &openrtb_ext.ExtBidPrebidMeta{
NetworkID: ext.DspId,
AdvertiserID: buyerId,
BrandID: ext.BrandId,
}
}

func getBuyerIdFromExt(ext *oxBidExt) int {
Copy link
Copy Markdown

@sergseven Serhii Nesprava (sergseven) Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function will work correctly
but still it's best practice to check for an empty value before passing value to strconv.Atoi() to avoid spawning an error each time there is no value available in json

Suggested change
func getBuyerIdFromExt(ext *oxBidExt) int {
func getBuyerIdFromExt(ext *oxBidExt) int {
if ext.BuyerId == "" {
return 0
}

Copy link
Copy Markdown
Author

@Fuska1 Kacper Fus (Fuska1) Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added, thanks for the suggestion

if ext.BuyerId == "" {
return 0
}
buyerId, err := strconv.Atoi(ext.BuyerId)
if err != nil {
return 0
}
return buyerId
}
114 changes: 114 additions & 0 deletions adapters/openx/openx_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package openx

import (
"encoding/json"
"net/http"
"testing"

"github.com/prebid/openrtb/v20/openrtb2"
Expand Down Expand Up @@ -33,6 +34,119 @@ func TestResponseWithCurrencies(t *testing.T) {
assertCurrencyInBidResponse(t, "EUR", &currency)
}

func TestOpenxAdapter_GetBidMeta(t *testing.T) {
testCases := []struct {
bid *openrtb2.Bid
expectedMeta *openrtb_ext.ExtBidPrebidMeta
}{
{
&openrtb2.Bid{Ext: json.RawMessage(`malformed`)},
nil,
},
{
&openrtb2.Bid{Ext: json.RawMessage(`{}`)},
nil,
},
{
&openrtb2.Bid{Ext: json.RawMessage(`{"dsp_id":"456","brand_id":"789","buyer_id":"123"}`)},
&openrtb_ext.ExtBidPrebidMeta{AdvertiserID: 123, NetworkID: 456, BrandID: 789},
},
{
&openrtb2.Bid{Ext: json.RawMessage(`{"dsp_id":"456","brand_id":"malformed","buyer_id":"123"}`)},
nil,
},
{
&openrtb2.Bid{Ext: json.RawMessage(`{"dsp_id":"456","brand_id":"789","buyer_id":"123-456"}`)},
&openrtb_ext.ExtBidPrebidMeta{AdvertiserID: 0, NetworkID: 456, BrandID: 789},
},
{
&openrtb2.Bid{Ext: json.RawMessage(`{"buyer_id":"123","dsp_id":"456"}`)},
&openrtb_ext.ExtBidPrebidMeta{AdvertiserID: 123, NetworkID: 456, BrandID: 0},
},
{
&openrtb2.Bid{Ext: json.RawMessage(`{"buyer_id":"123","brand_id":"789"}`)},
&openrtb_ext.ExtBidPrebidMeta{AdvertiserID: 123, NetworkID: 0, BrandID: 789},
},
{
&openrtb2.Bid{Ext: json.RawMessage(`{"dsp_id":"456","brand_id":"789"}`)},
&openrtb_ext.ExtBidPrebidMeta{AdvertiserID: 0, NetworkID: 456, BrandID: 789},
},
{
&openrtb2.Bid{Ext: json.RawMessage(`{"buyer_id":"123"}`)},
&openrtb_ext.ExtBidPrebidMeta{AdvertiserID: 123, NetworkID: 0, BrandID: 0},
},
{
&openrtb2.Bid{Ext: json.RawMessage(`{"dsp_id":"456"}`)},
&openrtb_ext.ExtBidPrebidMeta{AdvertiserID: 0, NetworkID: 456, BrandID: 0},
},
{
&openrtb2.Bid{Ext: json.RawMessage(`{"brand_id":"789"}`)},
&openrtb_ext.ExtBidPrebidMeta{AdvertiserID: 0, NetworkID: 0, BrandID: 789},
},
{
&openrtb2.Bid{Ext: json.RawMessage(`{"buyer_id":"123","dsp_id":"456"}`)},
&openrtb_ext.ExtBidPrebidMeta{AdvertiserID: 123, NetworkID: 456, BrandID: 0},
},
{
&openrtb2.Bid{Ext: json.RawMessage(`{"buyer_id":"malformed","dsp_id":"malformed","brand_id":"malformed"}`)},
nil,
},
}

for _, testCase := range testCases {
updatedMeta := getBidMeta(testCase.bid)
assert.Equal(t, testCase.expectedMeta, updatedMeta)
}
}

func TestOpenxAdapter_MakeBids(t *testing.T) {
responseBody := `{"id":"test-request-id","seatbid":[{"seat":"openx","bid":[{"id":"all-buyer-ext","impid":"all-buyer-ext-imp-id","price":0.5,"adm":"some-test-ad","crid":"crid_10","ext":{"dsp_id":"123","brand_id":"456","buyer_id":"789"},"h":90,"w":728,"mtype":1},{"id":"only-dspId","impid":"only-dspId-imp-id","price":0.6,"adm":"some-test-ad","crid":"crid_11","ext":{"dsp_id":"321"},"h":90,"w":728,"mtype":1}]}],"cur":"USD"}`
response := &adapters.ResponseData{
StatusCode: http.StatusOK,
Body: []byte(responseBody),
}
adapter := &OpenxAdapter{bidderName: "", endpoint: ""}
bids, _ := adapter.MakeBids(&openrtb2.BidRequest{}, &adapters.RequestData{}, response)
expectedBidderResponse := adapters.BidderResponse{
Currency: "USD",
Bids: []*adapters.TypedBid{
{
Bid: &openrtb2.Bid{
ID: "all-buyer-ext",
ImpID: "all-buyer-ext-imp-id",
Price: 0.5,
AdM: "some-test-ad",
CrID: "crid_10",
W: 728,
H: 90,
MType: 1,
Ext: json.RawMessage(`{"dsp_id":"123","brand_id":"456","buyer_id":"789"}`),
},
BidMeta: &openrtb_ext.ExtBidPrebidMeta{NetworkID: 123, BrandID: 456, AdvertiserID: 789},
BidType: "banner",
BidVideo: &openrtb_ext.ExtBidPrebidVideo{Duration: 0, PrimaryCategory: ""},
},
{
Bid: &openrtb2.Bid{
ID: "only-dspId",
ImpID: "only-dspId-imp-id",
Price: 0.6,
AdM: "some-test-ad",
CrID: "crid_11",
W: 728,
H: 90,
MType: 1,
Ext: json.RawMessage(`{"dsp_id":"321"}`),
},
BidMeta: &openrtb_ext.ExtBidPrebidMeta{NetworkID: 321},
BidType: "banner",
BidVideo: &openrtb_ext.ExtBidPrebidVideo{Duration: 0, PrimaryCategory: ""},
},
},
}
assert.Equal(t, expectedBidderResponse, *bids)
}

func assertCurrencyInBidResponse(t *testing.T, expectedCurrency string, currency *string) {
bidder, buildErr := Builder(openrtb_ext.BidderOpenx, config.Adapter{
Endpoint: "http://rtb.openx.net/prebid"}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})
Expand Down
Loading