fix(mcpp): mark all platforms res_versioned (consistent XLINGS_RES auto-bump) - #337
Merged
Conversation
…to-bump) mcpp is mirrored to xlings-res/mcpp and all version entries are XLINGS_RES sentinels, but only the linux block was bot-opted-in — via url_template, which makes version-check.py emit url+sha256 (github-only, no CN/GitCode fallback), inconsistent with the existing entries; macosx/windows had no marker at all so the bot skipped them (manual bumps). Replace linux's url_template with res_versioned=true and add it to macosx/windows. Now version-check.py --apply --only mcpp appends ["<ver>"]="XLINGS_RES" on all three platforms and bumps latest.ref, matching how mcpp is actually maintained (and how xlings itself works). The client never reads platform-level url_template (only the bot does; client resolves via the XLINGS_RES sentinel), so dropping it is safe. Enables the mcpp release pipeline's automated bump (mcpp-community/mcpp#194) to produce correct, mirror-backed entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Enables the mcpp release pipeline's automated index bump (mcpp-community/mcpp#194) to produce entries consistent with how mcpp is actually maintained.
Today
pkgs/m/mcpp.luais inconsistent:url_template→version-check.py --applywould emit["<ver>"] = { url = github.com/mcpp-community/..., sha256 }— github-only, no CN/GitCode fallback, and unlike every existing entry.["<ver>"] = "XLINGS_RES"(mcpp is mirrored toxlings-res/mcpp).What
Drop linux's
url_template, addres_versioned = trueto all three platforms. Nowversion-check.py --apply --only mcppappends["<ver>"] = "XLINGS_RES"on all three and bumpslatest.ref— matching the existing convention (and howxlingsitself is configured).Safe
The client never reads platform-level
url_template(verified:src/core/xim/installer.cppmonly expands version-entry-level Scheme-C templates; mcpp resolves via theXLINGS_RESsentinel →build_xlings_res_url_). Only the bot reads it. Not related to the github-gh V2url_templatemigration (#347).Verified
Simulated
--apply --only mcppagainst a rolled-back copy →{'linux':'XLINGS_RES','macosx':'XLINGS_RES','windows':'XLINGS_RES'},latest.refbumped.luaparse OK.Companion: openxlings/xlings#349, mcpp-community/mcpp#194.