Skip to content

Conversation

@elfkuzco
Copy link

@elfkuzco elfkuzco commented Feb 6, 2026

Rationale

This PR enhances the API/UI to create titles with a collection name and path
Screenshot_20260206_104332
Screenshot_20260206_104322

Changes

  • add endpoint to retrieve a list of collections
  • enhance model schema to create title so that values are NotEmptyStrings
  • add methods to retrieve the collection by name
  • remove occurences of using cookies to store user-preferences
  • add store for collections

This closes #139

@elfkuzco elfkuzco self-assigned this Feb 6, 2026
@elfkuzco elfkuzco requested a review from benoit74 February 6, 2026 09:50
@elfkuzco elfkuzco linked an issue Feb 6, 2026 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.89%. Comparing base (12e50ab) to head (2ed78a3).
⚠️ Report is 3 commits behind head on cms-upgrade.

Additional details and impacted files
@@               Coverage Diff               @@
##           cms-upgrade     #148      +/-   ##
===============================================
+ Coverage        77.05%   77.89%   +0.83%     
===============================================
  Files               40       40              
  Lines             1386     1434      +48     
  Branches           119      125       +6     
===============================================
+ Hits              1068     1117      +49     
+ Misses             280      279       -1     
  Partials            38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I realize my issue was not clear enough.

A title can be associated with 0 to n collections, not 0 or 1. We need to support assigning a title to two or more collections. Even if it is clearly not the default, and in general there will be only 1 collection, rarely 2, probably never 3 (just to take that into account in the UI).

And we should make the maturity default to dev (both in API and in UI).

@elfkuzco
Copy link
Author

elfkuzco commented Feb 6, 2026

Screenshot_20260206_164432 Screenshot_20260206_164410

@elfkuzco elfkuzco requested a review from benoit74 February 6, 2026 15:47
Copy link
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are getting close, one last requirement which was unclear obviously: 1 title can be associated with at most 1 collection. I.e. we need to detect duplicates on collection only, not collection + path. We cannot have a title association with collection1::path1 and with collection1:path2. We can only have collection1::path1 and collection2::path2. To be done both in backend and frontend obviously.

@benoit74
Copy link
Contributor

benoit74 commented Feb 9, 2026

Remark: on frontend, we should not even detect duplicates but rather prevent user from selecting a collection which is already associated with the title, this would be way more handy. And if there is only one single collection remaining left, it should be automatically selected.

@elfkuzco elfkuzco requested a review from benoit74 February 9, 2026 11:05
Copy link
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor wording fix, you can merge directly once applied, LGTM

@elfkuzco elfkuzco force-pushed the enhance-create-title-pop branch from 192f18b to 2ed78a3 Compare February 10, 2026 09:12
@elfkuzco elfkuzco merged commit 766976d into cms-upgrade Feb 10, 2026
6 checks passed
@elfkuzco elfkuzco deleted the enhance-create-title-pop branch February 10, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance the "Create Title" popup

2 participants