-
-
Notifications
You must be signed in to change notification settings - Fork 0
create title with collection name and path #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## cms-upgrade #148 +/- ##
===============================================
+ Coverage 77.05% 77.89% +0.83%
===============================================
Files 40 40
Lines 1386 1434 +48
Branches 119 125 +6
===============================================
+ Hits 1068 1117 +49
+ Misses 280 279 -1
Partials 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benoit74
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I realize my issue was not clear enough.
A title can be associated with 0 to n collections, not 0 or 1. We need to support assigning a title to two or more collections. Even if it is clearly not the default, and in general there will be only 1 collection, rarely 2, probably never 3 (just to take that into account in the UI).
And we should make the maturity default to dev (both in API and in UI).
benoit74
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are getting close, one last requirement which was unclear obviously: 1 title can be associated with at most 1 collection. I.e. we need to detect duplicates on collection only, not collection + path. We cannot have a title association with collection1::path1 and with collection1:path2. We can only have collection1::path1 and collection2::path2. To be done both in backend and frontend obviously.
|
Remark: on frontend, we should not even detect duplicates but rather prevent user from selecting a collection which is already associated with the title, this would be way more handy. And if there is only one single collection remaining left, it should be automatically selected. |
benoit74
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor wording fix, you can merge directly once applied, LGTM
192f18b to
2ed78a3
Compare


Rationale
This PR enhances the API/UI to create titles with a collection name and path


Changes
NotEmptyStringsThis closes #139