Skip to content

Conversation

@benoit74
Copy link
Collaborator

  • implement full e2e logic in the scraper to create a functional ZIM in terms of data (everything needed is there)
  • UI is definitely not yet correct, but this will follow

With this PR, it is possible to create a first functional ZIM of monaco area, proving the approach works well.

Note that for monaco area the ZIM size is a bit bigger than sum of tar.gz archives used to build it. Not a big surprise.

Downloaded data:

-rw-rw-r-- 1 benoit benoit 496K Feb 11 13:53 monaco.mbtiles
-rw-rw-r-- 1 benoit benoit 313M Feb 11 14:46 natural_earth.tar.gz
-rw-rw-r-- 1 benoit benoit  59M Feb 11 14:46 ofm.tar.gz
-rw-rw-r-- 1 benoit benoit 166K Feb 11 15:06 sprites.tar.gz
-rw-rw-r-- 1 benoit benoit  12K Feb 11 15:06 styles.tar.gz

ZIM:

-rw-r--r-- 1 benoit benoit 421M Feb 11 15:34 tests_maps_all_2026-02.zim

@benoit74 benoit74 self-assigned this Feb 11, 2026
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 9.24658% with 265 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.68%. Comparing base (6d3d0d2) to head (3abf5d7).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/maps2zim/processor.py 9.05% 261 Missing ⚠️
scraper/src/maps2zim/entrypoint.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #17       +/-   ##
===========================================
- Coverage   38.84%   23.68%   -15.17%     
===========================================
  Files          10       10               
  Lines         278      570      +292     
  Branches       16       61       +45     
===========================================
+ Hits          108      135       +27     
- Misses        170      435      +265     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 merged commit f4c8582 into main Feb 11, 2026
9 checks passed
@benoit74 benoit74 deleted the end_to_end branch February 11, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant