Skip to content

change zim download button behaviour#1060

Merged
audiodude merged 2 commits intoopenzim:mainfrom
ziaddevv:zim-download-and-manage-flow
Feb 16, 2026
Merged

change zim download button behaviour#1060
audiodude merged 2 commits intoopenzim:mainfrom
ziaddevv:zim-download-and-manage-flow

Conversation

@ziaddevv
Copy link
Copy Markdown
Contributor

@ziaddevv ziaddevv commented Jan 7, 2026

This PR solves three Issue related to Download button and schedule management UI

Screenshot_07-Jan_10-34-45_16

Issue #1006 :
Fix: Changed condition in ZimFile.vue
from !activeSchedule to status === 'FILE_READY' so it relies on the readiness of zim files not activeSchedule

Issue #991:
Fix: Added schedule checks to the backend API.
Updated MyLists.vue to:
Show “Manage Schedule” when a schedule exists
Allow users to download the ZIM file from the Manage Schedule view
Allow users to download the ZIM directly when a ZIM exists without a schedule
Show “Create ZIM” when no ZIM has been created yet

Issue #1000:
Fix: Solved by 991 - "Manage Schedule" button links directly to ZIM page where users can easily delete any scheduled files.

@ziaddevv
Copy link
Copy Markdown
Contributor Author

@audiodude any updates?

@audiodude audiodude force-pushed the zim-download-and-manage-flow branch from 6b3bf2f to bb920bf Compare February 16, 2026 16:59
@audiodude
Copy link
Copy Markdown
Member

Oh wow, sorry, I think this one fell off my radar. Thanks for the ping!

I'll take a look today.

@audiodude
Copy link
Copy Markdown
Member

Looks like tests are failing. Can you take a look? Thanks!

@ziaddevv
Copy link
Copy Markdown
Contributor Author

Looks like tests are failing. Can you take a look? Thanks!

looks like test are failing due to the new field "active_schedule" , I'll fix that

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 16, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.78%. Comparing base (8bdb235) to head (a67786a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
wp1/logic/builder.py 83.33% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (83.33%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1060      +/-   ##
==========================================
- Coverage   92.79%   92.78%   -0.02%     
==========================================
  Files          74       74              
  Lines        4291     4297       +6     
==========================================
+ Hits         3982     3987       +5     
- Misses        309      310       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ziaddevv ziaddevv force-pushed the zim-download-and-manage-flow branch from 86efdb3 to a67786a Compare February 16, 2026 19:40
@audiodude audiodude merged commit 814eb46 into openzim:main Feb 16, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants