change zim download button behaviour#1060
Conversation
|
@audiodude any updates? |
6b3bf2f to
bb920bf
Compare
|
Oh wow, sorry, I think this one fell off my radar. Thanks for the ping! I'll take a look today. |
|
Looks like tests are failing. Can you take a look? Thanks! |
looks like test are failing due to the new field "active_schedule" , I'll fix that |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (83.33%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
==========================================
- Coverage 92.79% 92.78% -0.02%
==========================================
Files 74 74
Lines 4291 4297 +6
==========================================
+ Hits 3982 3987 +5
- Misses 309 310 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
86efdb3 to
a67786a
Compare
This PR solves three Issue related to Download button and schedule management UI
Issue #1006 :
Fix: Changed condition in ZimFile.vue
from !activeSchedule to status === 'FILE_READY' so it relies on the readiness of zim files not activeSchedule
Issue #991:
Fix: Added schedule checks to the backend API.
Updated MyLists.vue to:
Show “Manage Schedule” when a schedule exists
Allow users to download the ZIM file from the Manage Schedule view
Allow users to download the ZIM directly when a ZIM exists without a schedule
Show “Create ZIM” when no ZIM has been created yet
Issue #1000:
Fix: Solved by 991 - "Manage Schedule" button links directly to ZIM page where users can easily delete any scheduled files.