🌱 Metrics Follow-Ups#2105
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2105 +/- ##
==========================================
+ Coverage 73.43% 73.49% +0.05%
==========================================
Files 78 78
Lines 7240 7240
==========================================
+ Hits 5317 5321 +4
+ Misses 1570 1567 -3
+ Partials 353 352 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dtfranz
force-pushed
the
metrics-follow-ups
branch
from
42acf74 to
c8b4d72
Compare
| curl -s "https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/refs/tags/${PROMETHEUS_VERSION}/bundle.yaml" > "${TMPDIR}/bundle.yaml" | ||
|
|
||
| echo "Patching namespace to ${PROMETHEUS_NAMESPACE}..." | ||
| (cd "$TMPDIR" && $KUSTOMIZE edit set namespace "$PROMETHEUS_NAMESPACE") |
There was a problem hiding this comment.
Nit: My preference is to use braces {} consistently throughout a script.
There was a problem hiding this comment.
How do you execute this command in a subshell with curly braces instead of ()? Assuming that's what you're talking about.
|
There are times when I like to separate out |
|
/approve |
openshift-ci
Bot
added
the
approved
Adding comment for traceability to prometheus alert rules. Move prometheus installation to new script to clean up makefile. Signed-off-by: Daniel Franz <dfranz@redhat.com>
dtfranz
force-pushed
the
metrics-follow-ups
branch
from
c8b4d72 to
f83f5e7
Compare
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
I am OK with this one. Great work 👍
/approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 850e4a1
into
operator-framework:main
3 participants
Follow-ups per feedback.
Adding comment for traceability to prometheus alert rules. Move prometheus installation to new script to clean up makefile.
Description
Reviewer Checklist