🌱 Internalize Test Pkgs

[dtfranz]

Description

Moves the test utils to internal/. This prevents them from being exported unintentionally and prevents go-apidiff from firing against test util code.

Inspired by this comment.

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	1bbf71f
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/689cd74b78599a0009d7ceba
😎 Deploy Preview	https://deploy-preview-2148--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[dtfranz]

The go-apidiff check will naturally fail here and will need an override for this to merge.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.75%. Comparing base (b9b5a7e) to head (1bbf71f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2148      +/-   ##
==========================================
+ Coverage   72.73%   72.75%   +0.01%     
==========================================
  Files          79       79              
  Lines        7340     7340              
==========================================
+ Hits         5339     5340       +1     
+ Misses       1654     1653       -1     
  Partials      347      347              

Flag	Coverage Δ
e2e	44.38% <ø> (?)
experimental-e2e	54.91% <ø> (ø)
unit	58.24% <ø> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[camilamacedo86]

That os great 👍

/lgtm

/overwrite go-apidiff

[tmshort]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tmshort]

I had to rebase...

[camilamacedo86]

/lgtm

[grokspawn]

/override go-apidiff

[openshift-ci]

@grokspawn: Overrode contexts on behalf of grokspawn: go-apidiff

Details

In response to this:

/override go-apidiff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.