✨ Upgrade boxcutter from v0.11.0 to v0.12.0#2594
Conversation
When k8s.io/client-go has a replace directive, `go list -m` outputs
"k8s.io/client-go v1.5.2 => k8s.io/client-go v0.35.0". Using
`cut -d" " -f2` picks the original version (v1.5.2) instead of the
replacement (v0.35.0), causing kind-verify-versions to fail with
"kindest/node:v1.35 version does not match k8s vv1.5.2" when
running `make verify`.
Replace `cut` with `awk '{print $NF}'` to always select the effective
version.
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
camilamacedo86
changed the title
camilamacedo86
changed the title
There was a problem hiding this comment.
Pull request overview
Updates the project’s Go dependency set to consume pkg.package-operator.run/boxcutter v0.12.0, pulling in a refreshed set of transitive Kubernetes/OpenTelemetry/etc. modules and adjusting build tooling to correctly derive the Kubernetes version from client-go.
Changes:
- Bump
pkg.package-operator.run/boxcutterfromv0.11.0tov0.12.0(and update transitive deps ingo.mod/go.sum). - Update a number of Kubernetes/OpenTelemetry-related dependency versions as part of the tidy result.
- Fix Makefile’s
K8S_VERSIONextraction to handlego list -moutput when a module is replaced.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
go.mod |
Updates Boxcutter + several dependency versions; adjusts Kubernetes-related module requirements. |
go.sum |
Refreshes checksums for updated direct/transitive dependencies. |
Makefile |
Updates K8S_VERSION parsing to use the effective (post-replace) module version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2594 +/- ##
==========================================
- Coverage 67.82% 67.76% -0.07%
==========================================
Files 137 137
Lines 9574 9574
==========================================
- Hits 6494 6488 -6
- Misses 2583 2586 +3
- Partials 497 500 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
openshift-merge-bot
Bot
merged commit 4ae0c6f
into
operator-framework:main
Description
Reviewer Checklist