Skip to content

🌱 Add test-identifying annotations to e2e resources#2701

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
pedjak:e2e-test-annotations
May 13, 2026
Merged

🌱 Add test-identifying annotations to e2e resources#2701
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
pedjak:e2e-test-annotations

Conversation

@pedjak
Copy link
Copy Markdown
Contributor

@pedjak pedjak commented May 13, 2026

Description

Inject e2e.olm.operatorframework.io/feature and e2e.olm.operatorframework.io/scenario annotations into every resource applied during an e2e scenario.

Currently, e2e test resources are named with opaque scenario IDs (e.g., ce-e3a7f5d2c1b94a2f). When debugging test failures on a cluster, there is no way to tell which feature/scenario a resource belongs to without cross-referencing test logs. These annotations make identification straightforward:

annotations:
  e2e.olm.operatorframework.io/feature: install
  e2e.olm.operatorframework.io/scenario: Install latest available version

The feature name is derived from the feature file path (e.g., features/install.featureinstall) and the scenario name comes directly from the Godog scenario.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Copilot AI review requested due to automatic review settings May 13, 2026 14:15
@openshift-ci openshift-ci Bot requested review from joelanford and perdasilva May 13, 2026 14:15
@netlify
Copy link
Copy Markdown

netlify Bot commented May 13, 2026

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 68cfdfb
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6a0494a7db59de00086196a9
😎 Deploy Preview https://deploy-preview-2701--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Inject e2e.olm.operatorframework.io/feature and
e2e.olm.operatorframework.io/scenario annotations into every resource
applied during an e2e scenario. This makes it possible to identify which
feature file and scenario produced a given resource when debugging test
failures on a cluster.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@pedjak pedjak force-pushed the e2e-test-annotations branch from b6e6fa2 to 68cfdfb Compare May 13, 2026 15:11
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.10%. Comparing base (10ea84d) to head (68cfdfb).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2701      +/-   ##
==========================================
- Coverage   68.12%   68.10%   -0.02%     
==========================================
  Files         145      145              
  Lines       10700    10700              
==========================================
- Hits         7289     7287       -2     
- Misses       2884     2885       +1     
- Partials      527      528       +1     
Flag Coverage Δ
e2e 36.83% <ø> (-0.31%) ⬇️
experimental-e2e 52.46% <ø> (-0.20%) ⬇️
unit 53.79% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented May 13, 2026

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 0d6fcd2 into operator-framework:main May 13, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants