Skip to content

Update blocknote to 0.39 and make necessary adjustments#36

Merged
brunopagno merged 2 commits intomainfrom
lib-maintenance
Sep 22, 2025
Merged

Update blocknote to 0.39 and make necessary adjustments#36
brunopagno merged 2 commits intomainfrom
lib-maintenance

Conversation

@brunopagno
Copy link
Collaborator

BlockNote 0.39 did some changes. I've tested out and needed to make one adjustment in the library, so releasing new version here

https://github.com/TypeCellOS/BlockNote/releases/tag/v0.39.0

Plus, I was reading more about peerDependencies in nodejs projects and the numbers there should probably be more lenient - https://nodejs.org/en/blog/npm/peer-dependencies

So BlockNote we kinda depend on 0.39+ now, but for react I am guessing it can be a bit broader

@brunopagno brunopagno requested a review from a team September 18, 2025 11:29
@brunopagno brunopagno self-assigned this Sep 18, 2025
Copy link
Contributor

@judithroth judithroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, only released 2 hours ago and you've done an update 🚀 🚀 🚀

Thanks for the link on peer dependencies! TIL :)
From the changes here I can't see why we would depend solely on blocknote greater than 0.39.0 now 😅 the article you linked advocates for having peer dependencies as relaxed as possible and I think that's a good advice.

However, something seems not to be working here. Not sure if the change was just a typo or on purpose.

@brunopagno brunopagno marked this pull request as draft September 19, 2025 07:00
@brunopagno brunopagno added the blocked Don't merge, please label Sep 19, 2025
@brunopagno
Copy link
Collaborator Author

The error on Chrome seems to happen inside BlockNote itself, so I ended up raising an issue with them.

My take is that we are not ready for 0.39, so I also marked as blocked the PR on OpenProject github.com/opf/openproject/pull/20367

Copy link
Contributor

@judithroth judithroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thanks for keeping us up-to-date.

@brunopagno brunopagno marked this pull request as ready for review September 22, 2025 12:44
@brunopagno brunopagno merged commit 4edfa4b into main Sep 22, 2025
4 checks passed
@brunopagno brunopagno deleted the lib-maintenance branch September 22, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Don't merge, please

Development

Successfully merging this pull request may close these issues.

2 participants