Update blocknote to 0.39 and make necessary adjustments#36
Conversation
There was a problem hiding this comment.
Wow, only released 2 hours ago and you've done an update 🚀 🚀 🚀
Thanks for the link on peer dependencies! TIL :)
From the changes here I can't see why we would depend solely on blocknote greater than 0.39.0 now 😅 the article you linked advocates for having peer dependencies as relaxed as possible and I think that's a good advice.
However, something seems not to be working here. Not sure if the change was just a typo or on purpose.
aebe9bc to
10efe5d
Compare
|
The error on Chrome seems to happen inside BlockNote itself, so I ended up raising an issue with them. My take is that we are not ready for 0.39, so I also marked as blocked the PR on OpenProject github.com/opf/openproject/pull/20367 |
judithroth
left a comment
There was a problem hiding this comment.
LGTM! 👍 Thanks for keeping us up-to-date.
BlockNote 0.39 did some changes. I've tested out and needed to make one adjustment in the library, so releasing new version here
https://github.com/TypeCellOS/BlockNote/releases/tag/v0.39.0
Plus, I was reading more about peerDependencies in nodejs projects and the numbers there should probably be more lenient - https://nodejs.org/en/blog/npm/peer-dependencies
So BlockNote we kinda depend on 0.39+ now, but for react I am guessing it can be a bit broader