Skip to content

Extract dev_tools from OP monorepo module#2

Merged
mrmir merged 4 commits intomainfrom
add-dev-tools-gem
Apr 17, 2026
Merged

Extract dev_tools from OP monorepo module#2
mrmir merged 4 commits intomainfrom
add-dev-tools-gem

Conversation

@mrmir
Copy link
Copy Markdown
Contributor

@mrmir mrmir commented Mar 4, 2026

Continuing from opf/openproject#22016

@mrmir mrmir requested review from machisuji and removed request for machisuji March 4, 2026 15:27
@mrmir mrmir requested a review from toy April 2, 2026 15:23
@mrmir
Copy link
Copy Markdown
Contributor Author

mrmir commented Apr 2, 2026

This took a while to get back to, but I incorporated whatever feedback I could from the other PR and I think it's ready to be merged now if you think so too @toy

Copy link
Copy Markdown

@toy toy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! I noted just few cleanup things and ideas

Comment thread README.md

## Tools

- **User switcher**: A dropdown in the top navigation bar listing all active users. Click any user to immediately switch to them.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought for future additions - it may be nice to be able to easily switch them on/off, like if they conflict with something or someone prefers to not have them all on

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea and will try to do something like that if I have more time in another PR. Gave it a quick test right now and was not happy with what I ended up with, so will try again later

Comment thread lib/open_project/dev_tools.rb Outdated
Comment thread lib/open_project/dev_tools/engine.rb Outdated
Comment thread config/routes.rb Outdated
Comment thread app/components/dev_tools_user_switcher/component.html.erb Outdated
Comment thread app/components/dev_tools_user_switcher/component.html.erb Outdated
Comment thread app/components/dev_tools_user_switcher/component.html.erb

current_user_name
end

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this, but maybe first user should be «Anonymous», as a quick way to see things logged out, also next menu has sign out

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into some issues while trying this so I've left it for now

Comment thread app/controllers/dev_tools/user_switcher_controller.rb
Comment thread config/locales/en.yml Outdated
@mrmir mrmir force-pushed the add-dev-tools-gem branch from 69c523e to ba329f3 Compare April 17, 2026 13:50
@mrmir mrmir merged commit b06945e into main Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants