Validate schemes for CopyToClipboardComponent#22141
Open
NobodysNightmare wants to merge 1 commit intodevfrom
Open
Validate schemes for CopyToClipboardComponent#22141NobodysNightmare wants to merge 1 commit intodevfrom
NobodysNightmare wants to merge 1 commit intodevfrom
Conversation
When trying to use this component, I wanted to use the input scheme that I copied from elsewhere in the code. At first I was surprised that the lookbook didn't yet contain a playground, where I could try this style out. After adding it, I was surprised that it didn't look like an input at all and learned that this scheme does not even exist... But it was already used multiple times :O
NobodysNightmare
force-pushed
the
copy-component-schemes
branch
from
fa6ff2d to
f6da3a3
Compare
HDinger
approved these changes
Mar 2, 2026
Contributor
HDinger
left a comment
HDinger
left a comment
There was a problem hiding this comment.
I am really not a fan of this component. It is a prime example for why we should not easily add "helper" components without thinking them through properly. Everything that's part of the notebook should be well defined...
Anyway (now that I'm done with ranting 😅), thanks for taking the time to update this. Looks good to me. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to use this component, I wanted to use the input scheme that I copied from elsewhere in the code. At first I was surprised that the lookbook didn't yet contain a playground, where I could try this style out.
After adding it, I was surprised that it didn't look like an input at all and learned that this scheme does not even exist... But it was already used multiple times :O
Ticket
none