fix: attribute source/owner on relationships in update_node

[PhillSimonds]

Problem

update_node (infrahub_sync/adapters/infrahub.py) sets source/owner attribution on updated attributes but not on updated relationships. A relationship changed by a sync therefore carries no lineage back to the sync's source/owner — most visible for update-only flows, where an object is matched and only its relationships/attributes are updated (never created). This is asymmetric with the create path, where generate_payload_create(..., source=..., owner=..., is_protected=True) attributes attributes and relationships alike.

Fixes #142.

Fix

Assign relationships via a data dict ({"id", "source", "owner"}) instead of the bare peer, in both the cardinality-one and cardinality-many branches. The SDK's RelatedNode reads source/owner from that dict and serialises them as _relation__source / _relation__owner in the mutation input — the same attribution the attribute path already applies.

Before → after:

# cardinality one
- setattr(node, attr_name, peer_node)
+ setattr(node, attr_name, _relationship_input_data(peer_node.id, source, owner))

# cardinality many
- attr_manager.add(new_id)
+ attr_manager.add(_relationship_input_data(new_id, source, owner))

source/owner are omitted from the dict when unset, so behaviour is unchanged when no source/owner is configured.

Tests

New tests/adapters/test_infrahub_update_node_attribution.py (12 tests):

• attributes still get source/owner (regression) — and none when unset
• cardinality-one relationship carries source/owner (and only id when unset)
• cardinality-many adds carry source/owner; stale peers still removed
• a real RelatedNodeSync built from the helper serialises to _relation__source / _relation__owner

The relationship tests were confirmed to fail against the pre-fix code. Full unit suite: 122 passed / 2 skipped. ruff check, ruff format --check, and ty check are all clean (no new diagnostics vs main).

Note

Scoped to source/owner to mirror the attribute-update path exactly. The create path additionally sets is_protected=True on relationships; this PR intentionally does not change protection on update (that would be a behaviour change beyond the attribution gap). Happy to add it if maintainers prefer full create/update parity.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Relationship updates now carry the same attribution details as other updates, including source and owner when provided.
  • One-to-one and one-to-many relationship changes now preserve attribution correctly while still handling added and removed peers as expected.
  • Relationship updates without attribution continue to work normally, using only the peer identifier.

[coderabbitai]

Walkthrough

Added a _relationship_input_data() helper in the Infrahub sync adapter that builds relationship payloads containing peer id plus optional source and owner fields. Updated update_node() to use this helper for both one-to-one relationship assignment and one-to-many relationship peer additions, replacing prior direct id/node assignments. Updated the update_node() docstring accordingly. Added a new test module with fake node/schema/client/manager stand-ins and regression tests verifying attribution behavior for attribute updates and both relationship cardinalities.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: adding source/owner attribution to relationship updates in update_node.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cloudflare-workers-and-pages]

Deploying infrahub-sync with    Cloudflare Pages

Latest commit:	ca9f9f5
Status:	✅  Deploy successful!
Preview URL:	https://bd1f4732.infrahub-sync.pages.dev
Branch Preview URL:	https://fix-update-node-relationship.infrahub-sync.pages.dev

View logs