Expose ImportError when trying to import config modules#19
Open
doismellburning wants to merge 1 commit intomasterfrom
Open
Expose ImportError when trying to import config modules#19doismellburning wants to merge 1 commit intomasterfrom
doismellburning wants to merge 1 commit intomasterfrom
Conversation
raise-ing a utils.ErrorMessage hides the details of the underlying exception without --debug As a user, I'd like a little more information about what has gone wrong when my tool has a critical failure like this - I don't want to have to re-run it (which could be nontrivial) I appreciate using debug logging for otherwise-overly-verbose information that might help me understand internal behaviour better, but for fundamental failures like "your config file is so broken that the tool won't run", I want useful information alongside the failure.
Contributor
Author
|
@jdelic Your thoughts here please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
raise-ing a utils.ErrorMessage hides the details of the underlying exception, unless you're running with --debug
As a user, I'd like a little more information about what has gone wrong when my tool has a critical failure like this - I don't want to have to re-run it (which could be nontrivial)
I appreciate using debug logging for otherwise-overly-verbose information that might help me understand internal behaviour better, but for fundamental failures like "your config file is so broken that the tool won't run", I want useful information alongside the failure.