Records & Tuples Proposal Implementation - #433
Conversation
|
Hello Christian Aistleitner, thanks for contributing a PR to our project! We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address christian -(dot)- aistleitner -(at)- outlook -(dot)- com. You can sign it at that link. If you think you've already signed it, please comment below and we'll check. |
# Conflicts: # graal-js/src/com.oracle.js.parser/src/com/oracle/js/parser/TokenType.java # graal-js/src/com.oracle.truffle.js.parser/src/com/oracle/truffle/js/parser/GraalJSTranslator.java # graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/access/ReadElementNode.java # graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/control/DeletePropertyNode.java
ba93d4c to
dd9b5d9
Compare
# Conflicts: # graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/cast/JSToInt32Node.java # graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/cast/JSToUInt32Node.java # graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/JSContext.java
|
Christian Aistleitner has signed the Oracle Contributor Agreement (based on email address christian -(dot)- aistleitner -(at)- outlook -(dot)- com) so can contribute to this repository. |
wirthi
left a comment
wirthi
left a comment
There was a problem hiding this comment.
Overall, looks great already! Thanks for implementing that.
A few things noted in the review, but nothing major so far, just comments around proper usage of Truffle and making sure this compiles nicely and produces fast code.
3 participants
ready for review