Skip to content

Added support for VScode Variables resolution in configs#579

Merged
sid-srini merged 1 commit intooracle:mainfrom
Achal1607:vscode-variables-support
Apr 8, 2026
Merged

Added support for VScode Variables resolution in configs#579
sid-srini merged 1 commit intooracle:mainfrom
Achal1607:vscode-variables-support

Conversation

@Achal1607
Copy link
Copy Markdown
Member

Added support for VSCode variables resolution in some of the selected configs.
At present configs which would support such resolution are related to notebooks, vmOptions, jdkhome, projectJdkHome and runConfigs.

closes #392

@Achal1607 Achal1607 added this to the JVSC 26.0.0 milestone Apr 2, 2026
@Achal1607 Achal1607 requested a review from sid-srini April 2, 2026 08:20
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 2, 2026
@Achal1607 Achal1607 force-pushed the vscode-variables-support branch 2 times, most recently from 64412a9 to 4aa53a7 Compare April 6, 2026 10:33
sid-srini
sid-srini previously approved these changes Apr 6, 2026
Copy link
Copy Markdown
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Achal1607 for this enhancement.

Minor comments are mentioned below. LGTM 👍

Comment thread vscode/src/configurations/configurationValueResolver/types.ts Outdated
Comment thread vscode/src/configurations/configurationValueResolver/utils.ts Outdated
Comment thread vscode/src/configurations/configurationValueResolver/utils.ts Outdated
Comment thread vscode/src/configurations/handlers.ts
Comment thread README.md Outdated
sid-srini
sid-srini previously approved these changes Apr 7, 2026
Copy link
Copy Markdown
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@Achal1607 Achal1607 force-pushed the vscode-variables-support branch from 4c96cc1 to 6f5ca09 Compare April 7, 2026 17:55
@Achal1607 Achal1607 requested a review from sid-srini April 7, 2026 17:56
@Achal1607 Achal1607 force-pushed the vscode-variables-support branch from 6f5ca09 to dc7f252 Compare April 7, 2026 18:00
Copy link
Copy Markdown
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Achal1607 for these improvements.

Comment thread vscode/src/utils.ts
@Achal1607 Achal1607 force-pushed the vscode-variables-support branch from dc7f252 to 36c5ad5 Compare April 8, 2026 04:37
@Achal1607 Achal1607 requested a review from sid-srini April 8, 2026 04:38
Copy link
Copy Markdown
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Achal1607. LGTM 👍

@sid-srini sid-srini merged commit 9d055c6 into oracle:main Apr 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suport environment variables in jdk.project.jdkhome settings

2 participants