introduce modelpack for model in OCI format#216
Open
CormickKneey wants to merge 1 commit intooras-project:mainfrom
Open
introduce modelpack for model in OCI format#216CormickKneey wants to merge 1 commit intooras-project:mainfrom
CormickKneey wants to merge 1 commit intooras-project:mainfrom
Conversation
Signed-off-by: cormick <cormick1080@gmail.com>
Contributor
|
Is this something you've discussed with the primary oras maintainers in slack, or is this feature already implemented in oras go? |
tarilabs
reviewed
Jul 31, 2025
| ) | ||
|
|
||
| # ModelPack annotations, refer to https://github.com/modelpack/model-spec/blob/main/specs-go/v1/annotations.go | ||
| annotation_filepath = "org.cnai.model.filepath" |
Contributor
There was a problem hiding this comment.
Suggested change
| annotation_filepath = "org.cnai.model.filepath" | |
| annotation_filepath = "org.cncf.model.filepath" |
to align with latest since Sandboxing.
Author
Sorry for the late response — I missed the email. I haven’t discussed this with the primary ORAS maintainers yet. Let me start a thread on Slack later this week! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the ORAS Python client to support multiple compression formats by implementing suffix-based compression detection, replacing hardcoded media type comparison with a flexible approach. So we can use this to support various media types (for example, from https://github.com/modelpack/model-spec/blob/main/specs-go/v1/mediatype.go) instead of the original specific one.
Key Changes
1. New Compression Functions (oras/utils/fileio.py)
zstandardpackage)2. Enhanced Provider Logic (oras/provider.py)
.tar.gz,.tar.zst,.tar)Compression Detection
Uses suffix matching to identify formats:
+gzipsuffix → gzip compression+zstdsuffix → zstd compression.tarsuffix → uncompressed tar.rawsuffix → raw files (no extraction)Dependencies
pip install zstandardfor zstd support