[Bounty $8k] fix(deploy): separate deploy credentials by environment with approval flow#3923
Open
neuralmint wants to merge 2 commits into
Open
Conversation
… flow Closes orchestration-agent#3921 - Add DeployCredentialManager with environment-scoped identities - Staging/development identities issued immediately - Production identities require explicit approval before use - EnvironmentMismatch raised when credential used against wrong env - Expired identities rejected - Full regression test suite (13 tests) Acceptance criteria met: - Staging credentials cannot modify production resources ✓ - Production deploy credentials issued only after approval ✓ - Deployment logs identify the environment-specific identity used ✓
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3921
Summary
DeployCredentialManagerwith environment-scoped identitiesEnvironmentMismatchraised when scoped credentials used against wrong environmentAcceptance Criteria
Tests
pytest -q tests/test_deploy_credentials.py/claim #3921