[SDK] Fix: run cleanup when BaseAgent.setup fails (#3765)#3936
Open
josemiguel3125-sketch wants to merge 1 commit into
Open
[SDK] Fix: run cleanup when BaseAgent.setup fails (#3765)#3936josemiguel3125-sketch wants to merge 1 commit into
josemiguel3125-sketch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3765
BaseAgent.run()calledself.setup()outside thetry/finallyblock. Ifsetup()raised an exception,self.cleanup()was never executed, leaking resources (open files, connections, locks).Changes
self.setup()inside thetryblock sofinallyalways runsself.cleanup()Tests
test_cleanup_called_when_setup_fails— verifies cleanup is called after setup raisestest_cleanup_called_on_normal_stop— verifies cleanup is called on graceful stopmake testAcceptance Criteria