fix: require auth for live update websocket token minting#3946
Open
pinehill99 wants to merge 5 commits into
Open
fix: require auth for live update websocket token minting#3946pinehill99 wants to merge 5 commits into
pinehill99 wants to merge 5 commits into
Conversation
Initial web commit for orchestration-agent#3912 auth middleware; remaining files will be added to the same fork branch before opening the PR.
Part of orchestration-agent#3912 live-update auth fix.
Part of orchestration-agent#3912 live-update auth fix.
Part of orchestration-agent#3912 live-update auth fix.
Part of orchestration-agent#3912 live-update auth fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
live_updates:token:mintscope before live-update websocket token mintingao_sessionbrowser clients while rejecting anonymous, stale, revoked, wrong-workspace, insufficient-role, insufficient-scope, and query-string-token clientsFixes #3912
Validation
python3 -m pytest tests/test_live_update_auth.py -q(9 passed)python3 -m pytest tests/test_live_update_auth.py tests/test_agent_registry.py tests/test_scheduler.py tests/test_config.py -q(27 passed)python3 -m py_compile src/api/auth.py src/api/middleware.py src/api/routes.py src/agent/__init__.py tests/test_live_update_auth.pyuv run flake8 src/api/auth.py src/api/middleware.py src/api/routes.py src/agent/__init__.py tests/test_live_update_auth.pygit diff --checkFull
python3 -m pytest tests -qwas attempted and stopped after hanging at the pre-existingtests/test_metrics.py::TestMetricsCollector::test_timer; full-suite pass is not claimed.