fix: add server-side file type validation for drag-and-drop import widget#4459
Open
neuralmint wants to merge 1 commit into
Open
fix: add server-side file type validation for drag-and-drop import widget#4459neuralmint wants to merge 1 commit into
neuralmint wants to merge 1 commit into
Conversation
…dget Implements server-side content validation for the import upload endpoint. The client-side extension filter is now reinforced by MIME-type and magic-byte checks on the server, preventing renamed or unsupported files from reaching the import parser. Changes: - Add src/common/validation.py with validate_import_file() and detection heuristics - Add POST /api/v2/import endpoint with UploadFile support - Add python-multipart dependency to pyproject.toml - Add 25 tests covering extension, MIME, rename, and binary detection Closes orchestration-agent#4456
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4456
Summary
Adds server-side file type validation for the drag-and-drop import widget so that renamed or unsupported files are rejected regardless of what the client-side filter allows through.
Changes
src/common/validation.py— server-side file validation with extension, MIME-type, and magic-byte checkssrc/api/routes.py—POST /api/v2/importendpoint withUploadFilesupporttests/test_import.py— 25 tests covering valid inputs, renamed files, binary detection, and edge casespyproject.toml— addedpython-multipartdependencyAcceptance Criteria
ACCEPTED_EXTENSIONSandACCEPTED_MIME_TYPESinvalidation.py)