fix: add redaction policy to support diagnostics bundle#4460
Open
neuralmint wants to merge 1 commit into
Open
Conversation
Implements a recursive redaction function and a generate_diagnostics_bundle() entry point for the operator-facing diagnostics endpoint. Sensitive fields (token, password, secret, api_key, credential, etc.) are redacted at every nesting level before the bundle is returned. Changes: - Add src/common/diagnostics.py with redact() and generate_diagnostics_bundle() - Recursive redaction covers all dict keys at any depth - Sensitive key patterns include connection strings and credential fields - Health diagnostics bundle collects system info without leaking secrets - Add 16 tests covering key detection, scalar/list/nested redaction, bundle integrity Closes orchestration-agent#4453
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4453
Summary
Adds a redaction policy and diagnostics bundle generator so that sensitive fields (tokens, passwords, secrets, credentials, API keys) are stripped from operator-facing diagnostic output.
Changes
src/common/diagnostics.py—redact()recursively walks dicts/lists and replaces sensitive values with[REDACTED]placeholderssrc/common/diagnostics.py—generate_diagnostics_bundle()builds a system metadata bundle and applies redaction to agent registry snapshots and configtests/test_diagnostics.py— 16 tests covering key detection, scalar/list/nested redaction, bundle structural integrity, and end-to-end no-leakage verificationAcceptance Criteria