fix: persist discount fields when clearing quote discount#58
Merged
Conversation
The updateQuote action used a spread pattern `...(discountType && {...})`
which silently dropped null values — clearing a discount had no effect.
Changed to always persist discount fields with explicit null.
Also merged `data.settings` from the form into the saved settings JSON
so deposit/signature preferences are not lost on save.
Fixes #55
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateQuoteused...(discountType && { discountType })which silently dropped null values — clearing a discount had no effectdiscountType: discountType || nulldata.settingsfrom the form into saved settings JSON so deposit/signature preferences are not lost on saveTest plan
Fixes #55
🤖 Generated with Claude Code