perf(benchmark): bound terminal run/batch registries - #738
Open
beruro wants to merge 3 commits into
Open
Conversation
beruro
marked this pull request as ready for review
August 8, 2026 12:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The process-wide benchmark run and batch registries retained every terminal entry for the lifetime of the app. Repeated benchmark use therefore grew memory without a bound, and evaluator subprocesses could remain alive when the app exited.
Solution
The branch is merged with the current
develop; GitHub reports it mergeable.Potential risks
try_lockand SIGTERM, so it is best-effort and cannot cover a hard process kill.Audit
Architecture review covered registry ownership, status/FSM classification, persistence fallback, lock boundaries, process lifecycle, and IPC compatibility. Performance-guard verdict: pass — terminal memory is capped, active work is not evicted, pruning runs only at existing mutations, no idle/background loop was introduced, and reopen/reload uses the existing persisted batch path.
Verification
CARGO_TARGET_DIR=/Users/junyu/github/ORGII/src-tauri/target cargo test -p org2 benchmark::retention— PASS, 11 passed / 0 failed.rustfmton the touched Rust files — PASS.git diff --check— PASS.origin/develop— PASS, no conflicts; targeted tests were run after integration.