fix(benchmark): remove personal SWE-bench path defaults - #739
Open
beruro wants to merge 3 commits into
Open
Conversation
beruro
marked this pull request as ready for review
August 8, 2026 12:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The SWE-bench Pro harness default embedded one developer's absolute macOS path. It was invalid on other machines, leaked a personal directory layout, and delayed the configuration error until filesystem access.
Solution
benchmark/paths.rswith explicit precedence: caller-provided value, thenORGII_SWE_BENCH_PRO_REPO_PATH, then a typed not-configured error.The branch is merged with the current
develop; GitHub reports it mergeable.Potential risks
ORGII_SWE_BENCH_PRO_REPO_PATHinstead of relying on the removed implicit path. This is the intended compatibility break.local_dockermode, missing configuration now fails during plan creation instead of returning a plan that fails later. The existing frontend error path handles the returned message; no DTO or wire shape changed.Verification
cargo test -p org2 benchmark::paths— PASS, 7 passed / 0 failed.rg -n "/Users/laptop-h|/Users/junyu" src-tauri/src/benchmark/— PASS, no personal path remains.git diff --check— PASS.origin/develop— PASS, no conflicts; targeted tests were run after integration.